Bug 475282

Description Alex Pogrebnyak 2015-08-18 13:44:52 EDT

Create this class foo/bar/Foo.java

===============
package foo.bar

/**
 * Copyright notice
 */

import java.util.List;

public class Foo
{
  List list;
}
===============

Save file.

Now add reference to java.util.Calendar

===============
package foo.bar

/**
 * Copyright notice
 */

import java.util.List;

public class Foo
{
  Calendar calendar;
  List list;
}
===============

Eclipse correctly highlights error on a new line.
Now QuickFix the calendar reference by accepting 'Import Calendar (java.util)'.

BUG -> new import statement appears before Copyright notice.

===============
package foo.bar

import java.util.Calendar;

/**
 * Copyright notice
 */

import java.util.List;

public class Foo
{
  Calendar calendar;
  List list;
}
=============

This behavior is new to Luna.  Previously used Eclipse version (Kepler), inserted new import line right before 'import java.util.List;' statement.

BTW, I do understand that it is not easy to find a correct place for the Only and First import statement, and for this, appending it after 'package' statement is as good default as any other.  However, when there are already existing imports in the file, QuickFix should pay attention to where they start.

This may be linked to issue with Cleanup eagerly removing first import statement -> https://bugs.eclipse.org/bugs/show_bug.cgi?id=475281