Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 475190

Summary:	Refactor semantic zooming related parts of Zest.FX
Product:	[Tools] GEF	Reporter:	Alexander Nyßen <nyssen>
Component:	GEF Zest	Assignee:	gef-inbox <gef-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	matthias.wienand
Version:	0.1.0
Target Milestone:	4.0.0 / 3.11.0 (Neon) M4
Hardware:	All
OS:	All
Whiteboard:

Description Alexander Nyßen

2015-08-17 12:50:28 EDT

While the immanent problems related to semantic zooming have been resolved (see bug #466815), the API still needs to be (partially) refactored. Especially the behaviors that realize semantic zooming (OpenNestedGraphOnZoomBehavior, OpenParentGraphOnZoomBehavior) need to be revised, and should probably be realized as policies instead.

Comment 1 Matthias Wienand

2015-11-19 10:12:52 EST

While resolving bug #482333, I removed the Open*OnZoomBehavior classes. The functionality is now provided within a specialized FXChangeViewportPolicy, called SemanticZoomPolicy. However, the NavigationPolicy is still needed for the Open*OnDoubleClickPolicy classes. Therefore, the SemanticZoomPolicy and the NavigationPolicy share some code. This can probably be refactored so that both policies use an operation for opening a nested/nesting graph.

Comment 2 Matthias Wienand

2015-11-27 05:23:23 EST

I removed the NavigationPolicy and provided its functionality within a newly created NavigateOperation. I further refactored the SemanticZoomPolicy so that it also uses the NavigateOperation to perform its changes.

The code is published on the master branch, therefore, I resolve this ticket as fixed for 3.11.0M4.