Bugzilla – Full Text Bug Listing
| Summary: | Data race on org.eclipse.swt.widgets.Display.wake inside org.eclipse.ui.application.WorkbenchAdvisor.openWindows | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Yilong Li <yilong.li> |
| Component: | UI | Assignee: | Platform-UI-Inbox <Platform-UI-Inbox> |
| Status: | CLOSED WONTFIX | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | ||
| Version: | 4.6 | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Whiteboard: | stalebug | ||
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug. If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie. |
The data race is on org.eclipse.swt.widgets.Display.wake but I suspect the problem is on the caller side, which is the WorkBenchAdvisor. Here is the data race report given by a dynamic race detector: Data race on field org.eclipse.swt.widgets.Display.wake: {{{ Concurrent write in thread T1 (locks held: {}) ----> at org.eclipse.swt.widgets.Display.sleep(Display.java:4319) at org.eclipse.ui.application.WorkbenchAdvisor.openWindows(WorkbenchAdvisor.java:827) at org.eclipse.ui.internal.Workbench$24.runWithException(Workbench.java:1682) at org.eclipse.ui.internal.StartupThreading$StartupRunnable.run(StartupThreading.java:32) at org.eclipse.swt.widgets.Synchronizer.syncExec(Synchronizer.java:186) at org.eclipse.ui.internal.UISynchronizer.syncExec(UISynchronizer.java:145) at org.eclipse.swt.widgets.Display.syncExec(Display.java:4633) at org.eclipse.ui.internal.StartupThreading.runWithoutExceptions(StartupThreading.java:95) at org.eclipse.ui.internal.Workbench.init(Workbench.java:1674) at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2968) at org.eclipse.ui.internal.Workbench.access$8(Workbench.java:2854) at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:651) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:598) at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150) at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:139) at org.eclipse.test.UITestApplication.runApplication(UITestApplication.java:140) at org.eclipse.test.UITestApplication.run(UITestApplication.java:62) at org.eclipse.test.UITestApplication.start(UITestApplication.java:212) at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243) at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:669) at org.eclipse.equinox.launcher.Main.basicRun(Main.java:608) at org.eclipse.equinox.launcher.Main.run(Main.java:1515) at org.eclipse.equinox.launcher.Main.main(Main.java:1488) at org.eclipse.core.launcher.Main.main(Main.java:34) T1 is the main thread Concurrent write in thread T32 (locks held: {Monitor@6e1d5ed6}) ----> at org.eclipse.swt.widgets.Display.wakeThread(Display.java:4694) at org.eclipse.swt.widgets.Display.wake(Display.java:4688) - locked Monitor@6e1d5ed6 at org.eclipse.swt.widgets.Display.wake(Display.java:4685) at org.eclipse.ui.application.WorkbenchAdvisor$1.run(WorkbenchAdvisor.java:818) T32 is created by T1 at org.eclipse.ui.application.WorkbenchAdvisor.openWindows(WorkbenchAdvisor.java:821) }}} Data race on field org.eclipse.swt.widgets.Display.wake: {{{ Concurrent read in thread T1 (locks held: {}) ----> at org.eclipse.swt.widgets.Display.sleep(Display.java:4330) at org.eclipse.ui.application.WorkbenchAdvisor.openWindows(WorkbenchAdvisor.java:827) at org.eclipse.ui.internal.Workbench$24.runWithException(Workbench.java:1682) at org.eclipse.ui.internal.StartupThreading$StartupRunnable.run(StartupThreading.java:32) at org.eclipse.swt.widgets.Synchronizer.syncExec(Synchronizer.java:186) at org.eclipse.ui.internal.UISynchronizer.syncExec(UISynchronizer.java:145) at org.eclipse.swt.widgets.Display.syncExec(Display.java:4633) at org.eclipse.ui.internal.StartupThreading.runWithoutExceptions(StartupThreading.java:95) at org.eclipse.ui.internal.Workbench.init(Workbench.java:1674) at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2968) at org.eclipse.ui.internal.Workbench.access$8(Workbench.java:2854) at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:651) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:598) at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150) at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:139) at org.eclipse.test.UITestApplication.runApplication(UITestApplication.java:140) at org.eclipse.test.UITestApplication.run(UITestApplication.java:62) at org.eclipse.test.UITestApplication.start(UITestApplication.java:212) at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243) at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:669) at org.eclipse.equinox.launcher.Main.basicRun(Main.java:608) at org.eclipse.equinox.launcher.Main.run(Main.java:1515) at org.eclipse.equinox.launcher.Main.main(Main.java:1488) at org.eclipse.core.launcher.Main.main(Main.java:34) T1 is the main thread Concurrent write in thread T32 (locks held: {Monitor@6e1d5ed6}) ----> at org.eclipse.swt.widgets.Display.wakeThread(Display.java:4694) at org.eclipse.swt.widgets.Display.wake(Display.java:4688) - locked Monitor@6e1d5ed6 at org.eclipse.swt.widgets.Display.wake(Display.java:4685) at org.eclipse.ui.application.WorkbenchAdvisor$1.run(WorkbenchAdvisor.java:818) T32 is created by T1 at org.eclipse.ui.application.WorkbenchAdvisor.openWindows(WorkbenchAdvisor.java:821) }}} As you can see, the accesses to Display.wake are not synchronized properly. This could be related to https://bugs.eclipse.org/bugs/show_bug.cgi?id=243855.