Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 474878

Summary: Improve the integration of AQL in the interpreter
Product: [Modeling] Sirius Reporter: Stephane Begaudeau <stephane.begaudeau>
Component: CoreAssignee: Stephane Begaudeau <stephane.begaudeau>
Status: CLOSED FIXED QA Contact: Maxime Porhel <maxime.porhel>
Severity: enhancement    
Priority: P3 CC: laurent.redor, maxime.porhel, pierre-charles.david
Version: 3.0.0Keywords: triaged
Target Milestone: 3.1.0   
Hardware: All   
OS: All   
See Also: https://git.eclipse.org/r/53690
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=0c1dbd65678f5400049aa0390975942b86163080
https://git.eclipse.org/r/56849
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=90f4cc30054957aa8376572ed9391a02882687d1
Whiteboard:
Bug Depends on:    
Bug Blocks: 470460    
Attachments:
Description Flags
Screenshot none

Description Stephane Begaudeau CLA 2015-08-13 05:42:16 EDT 
1 - If an AQL expression has a warning, nothing is displayed (if something crashes it is displayed, everything else is considered ok).
2 - If an AQL expression returns a collection, we display its real Java type (ArrayList for example) that's an implementation detail.
3 - If the result of an evaluation is an EObject, we display the name of its java Class (again, an implementation detail) not the qualified name of its type.
4 - Pretty much everything in AQL is represented using a diagnostic with children so we need to be able to create MultiStatus object to represents all the error s or warnings found.

For the problems 1 and 3, see that SiriusEvaluationTask.createResultStatus(Object) can only create OK status not WARNING or ERROR ones (an error can only be triggered by AQL throwing an exception). In AQLSiriusInterpreter, we have all the relevant pieces of information to display a proper warning or error message and we discard them to give the result to SiriusEvaluationTask.
Comment 1 Eclipse Genie CLA 2015-08-13 05:46:54 EDT 
New Gerrit change created: https://git.eclipse.org/r/53690
Comment 2 Stephane Begaudeau CLA 2015-08-13 05:47:56 EDT 
Created attachment 255837 [details]
Screenshot

I have attached a screenshot of the result of the review
Comment 4 Pierre-Charles David CLA 2015-08-31 09:59:56 EDT 
Fixed by 0c1dbd65678f5400049aa0390975942b86163080.
Comment 5 Eclipse Genie CLA 2015-09-28 08:45:38 EDT 
New Gerrit change created: https://git.eclipse.org/r/56849
Comment 7 Maxime Porhel CLA 2015-10-14 10:02:03 EDT 
Validated on Sirius 3.1.0.201510130903
Comment 8 Pierre-Charles David CLA 2015-10-16 09:11:40 EDT 
Available in Sirius 3.1.0.