Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 474845

Summary:	git-author-icon image needs alt text
Product:	[ECD] Orion	Reporter:	Carolyn MacLeod <Carolyn_MacLeod>
Component:	Client	Assignee:	Carolyn MacLeod <Carolyn_MacLeod>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	unspecified
Target Milestone:	10.0
Hardware:	PC
OS:	Windows 7
See Also:	https://git.eclipse.org/r/56006 https://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=c6ff16e935c87fd861e54fd20589c5a762c13b75
Whiteboard:

Description Carolyn MacLeod

2015-08-12 19:15:07 EDT

The git author images have a name attribute but they need an alt attribute.
The <img> tag no longer supports the name attribute, so should probably just change
 image.name = commit.AuthorName;
to
 image.alt = commit.AuthorName;
in
 git/widgets/gitCommitInfo.js

Comment 1 Carolyn MacLeod

2015-09-15 12:08:17 EDT

Actually, since the author name is already shown in the git commit info, I think it would be better to just use alt="" for the alt text for these, because they are really just presentational.

Comment 2 Eclipse Genie

2015-09-15 13:15:04 EDT

New Gerrit change created: https://git.eclipse.org/r/56006

Comment 3 Eclipse Genie

2015-09-17 14:22:15 EDT

Gerrit change https://git.eclipse.org/r/56006 was merged to [master].
Commit: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=c6ff16e935c87fd861e54fd20589c5a762c13b75

Comment 4 Carolyn MacLeod

2015-09-17 15:39:31 EDT

Changes have been pushed.