Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 474711

Summary: TypeError: this.$frame is undefined (in dialog.js)
Product: [ECD] Orion Reporter: Grant Gayed <grant_gayed>
Component: ClientAssignee: Grant Gayed <grant_gayed>
Status: RESOLVED WORKSFORME QA Contact:
Severity: normal    
Priority: P3    
Version: 10.0   
Target Milestone: ---   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Grant Gayed CLA 2015-08-11 10:35:17 EDT
An error has been logged 7 unique times in the last 3 days, always on Firefox:

if (this._modalListener) {
	this.$frameParent.removeEventListener("focus", this._modalListener, true);  //$NON-NLS-0$
	this.$frameParent.removeEventListener("click", this._modalListener, true);  //$NON-NLS-0$
}

this.$frame.classList.remove("dialogShowing"); //$NON-NLS-0$ // <------
lib.setFramesEnabled(true);
if (typeof this._afterHiding === "function") { //$NON-NLS-0$
	this._afterHiding();
}

In the line marked above, this.$frame can evaluate to undefined.  There aren't known steps to reproduce the problem, but it was logged in minified file git-repository.js, indicating that it was attempting to show a dialog from the git page.
Comment 1 Grant Gayed CLA 2015-10-09 16:08:01 EDT
There have been no occurrences of this over the last month, so it appears to no longer be happening, closing report.