Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 474688

Summary:	Wrong first or last GMF bendpoint in case of rectilinear router and segment removal
Product:	[Modeling] Sirius	Reporter:	Laurent Redor <laurent.redor>
Component:	Diagram	Assignee:	Project Inbox <sirius.diagram-inbox>
Status:	CLOSED FIXED	QA Contact:	Julien Dupont <julien.dupont>
Severity:	normal
Priority:	P3	CC:	julien.dupont
Version:	2.0.0	Keywords:	triaged
Target Milestone:	3.1.0
Hardware:	PC
OS:	All
See Also:	https://bugs.eclipse.org/bugs/show_bug.cgi?id=452651 https://bugs.eclipse.org/bugs/show_bug.cgi?id=474672 https://git.eclipse.org/r/53539 https://bugs.eclipse.org/bugs/show_bug.cgi?id=474828 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=1a5df2d52c19f9b69d9f9dd7226b8b99a3b15426 https://git.eclipse.org/r/54401 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=22a545643fcb6b6306405803b2d2f8c22ed7ca25
Whiteboard:
Bug Depends on:
Bug Blocks:	465328

Description Laurent Redor

2015-08-11 05:45:23 EDT

As for bug 474672, this bug completes the initial bug 452651. When the first (or last) segment is removed during the node move, the computed GMF points in SetConnectionBendpointsAccordingToExtremityMoveCommmand are KO.

Steps to reproduce: A gerrit with changes in BendpointsStabilityOnMovesSpecificCasesTest will be added to reveal this problem.

Comment 1 Eclipse Genie

2015-08-11 05:48:11 EDT

New Gerrit change created: https://git.eclipse.org/r/53539

Comment 2 Laurent Redor

2015-08-11 05:48:44 EDT

The gerrit https://git.eclipse.org/r/53539 corresponds to the automatic test modifications that reveals the problem.

Comment 3 Eclipse Genie

2015-08-19 05:16:30 EDT

Gerrit change https://git.eclipse.org/r/53539 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=1a5df2d52c19f9b69d9f9dd7226b8b99a3b15426

Comment 4 Laurent Redor

2015-08-19 05:17:32 EDT

The above gerrit fix the problem.

Comment 5 Laurent Redor

2015-08-24 08:26:53 EDT

The code does not handled correctly the case where a node is move along a segment so that segment is inverted (origin of segment at right became origin at left or the contrary)

The test BendpointsStabilityOnMovesSpecificCasesTest has been updated to reveal this problem.

Comment 6 Eclipse Genie

2015-08-24 08:27:51 EDT

New Gerrit change created: https://git.eclipse.org/r/54401

Comment 7 Eclipse Genie

2015-08-25 08:46:02 EDT

Gerrit change https://git.eclipse.org/r/54401 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=22a545643fcb6b6306405803b2d2f8c22ed7ca25

Comment 8 Laurent Redor

2015-08-25 08:46:54 EDT

Pb of comment 5 fixed with above commit.

Comment 9 Julien Dupont

2015-09-29 05:42:48 EDT

SwtBot Test BendpointsStabilityOnMovesSpecificCasesTes was ok.

Comment 10 Pierre-Charles David

2015-10-16 09:10:44 EDT

Available in Sirius 3.1.0.