Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 474639

Summary:	[solstice] cGit web interface: source view out of sync with line numbers
Product:	Community	Reporter:	Markus Keller <markus.kell.r>
Component:	Git	Assignee:	Eclipse Webmaster <webmaster>
Status:	RESOLVED FIXED	QA Contact:
Severity:	major
Priority:	P3	CC:	denis.roy
Version:	unspecified
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:

Description Markus Keller

2015-08-10 15:09:43 EDT

In the cGit web interface, the source view is out of sync with line numbers.

Example: http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/tree/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/util/Util.java?h=BETA_JAVA9&id=b0e07bcb3f2a6fb8c842095707a7fcc2f6f86c34#n866

This link should take you to line 866 of that source file, which reads:

for (String mod : modules) {
	return Files.newInputStream(fs.getPath(MODULES_SUBDIR, mod, fileName));
}

This doesn't work because styles.min.css adds two bad style properties:

pre code { [..]
    white-space: pre-wrap; [..]
}
pre {
    overflow: auto;
}

At least in cGit, "white-space" must stay at "pre", and the width must not be limited arbitrarily (or at least not by adding an artificial scrollbar).

Comment 1 Eclipse Genie

2017-07-31 13:14:31 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.

Comment 2 Eclipse Genie

2019-07-22 11:28:57 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.

Comment 3 Eclipse Webmaster

2019-07-24 10:21:28 EDT

Assigning to the webdev team.

-M.

Comment 4 Denis Roy

2021-12-20 15:40:03 EST

Looks in sync to me. I think the later versions fixed this.