Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 474516

Summary: Editor Styles Settings page should wrap style labels in <label for>
Product: [ECD] Orion Reporter: Carolyn MacLeod <Carolyn_MacLeod>
Component: ClientAssignee: Carolyn MacLeod <Carolyn_MacLeod>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: Silenio_Quarti
Version: 8.0   
Target Milestone: 10.0   
Hardware: PC   
OS: Windows 7   
See Also: https://git.eclipse.org/r/53556
https://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=840564c581ff4b20ad41c4563a854f8186a854fc
Whiteboard:
Attachments:
Description Flags
patch to fix font size and colors none

Description Carolyn MacLeod CLA 2015-08-07 14:53:22 EDT 
The Theme, Font size, and all of the color labels (Background, etc) should be in a <label for> element (not a <span>) where the for= attribute points to the corresponding select or color input element. This would result in 2 improvements:
1) The color inputs and selects would have a name label for accessibility purposes
2) The user could click on a label to open the corresponding color input (i.e. not just on the little circle/square of color).
Comment 1 Carolyn MacLeod CLA 2015-08-07 16:56:23 EDT 
Created attachment 255715 [details]
patch to fix font size and colors

Here is a "text patch" <g> for the Font size and color labels.
I'll figure out how to commit it through Gerrit on Monday.
Changes are in file themes/ThemeBuilder.js

Regarding the Theme combo, I have a couple of questions before I make the change:
1) Why is there a space between Theme and : ? (i.e. does someone care, or is it just a typo)
2) Why is there ${ } for the first Theme span (line 213)? (it's not on the 2nd span on line 219).
3) Is there a reason why "Theme:" isn't externalized? There is a "Theme:" defined in settings/nls/root/messages.js on line 216.

SSQ, do you know the reasons?
Comment 2 Silenio Quarti CLA 2015-08-10 11:08:00 EDT 
Both strings should have the ${} so that they get externalized. The string in the ${} must match the key in the messages file.

Just remove the space. Nobody cares.
Comment 3 Eclipse Genie CLA 2015-08-11 10:34:15 EDT 
New Gerrit change created: https://git.eclipse.org/r/53556
Comment 5 Carolyn MacLeod CLA 2015-10-02 17:15:54 EDT 
This was fixed a while ago.