Bugzilla – Full Text Bug Listing
| Summary: | [Core] Default naming for CapsuleParts and Ports should be enhanced | ||
|---|---|---|---|
| Product: | [Modeling] Papyrus-rt | Reporter: | Remi Schnekenburger <rschnekenburger> |
| Component: | core | Assignee: | Christian Damus <give.a.damus> |
| Status: | CLOSED FIXED | QA Contact: | Peter Cigehn <peter.cigehn> |
| Severity: | enhancement | ||
| Priority: | P3 | CC: | papyrus-bugs, peter.cigehn |
| Version: | 1.0.0 | ||
| Target Milestone: | 0.8.0 | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://git.eclipse.org/r/71955 https://git.eclipse.org/c/papyrus-rt/org.eclipse.papyrus-rt.git/commit/?id=c08a1afb207370fb97552e9968e2a04483be43ea |
||
| Whiteboard: | |||
|
Description
Remi Schnekenburger
I have not had the time yet to test the latest build, but from the description I get the impression the capsule part and ports currently are named *exactly* the same as its type, i.e. capsule respectively protocol. Just to clarify, the name of the capsule part and the port should by defaylt have the same name as its type, but with the a lower case of the initial letter, e.g. capsule part typed by MyCapsule should be named myCapsule and port typed by MyProtocol should be named myProtocol. And yes, as already proposed, a unique suffix should be added in case multiple capsule parts and ports are created type by the same type, i.e. if a second capsule part or port is created then its name should be suffixed with a 2 (and so on). Names have the first letter in lower case. However, we are still not using a suffix to distinguish among several names. This should be updated, and test should be developped according to this rule. I tried to create a port using the new child menu, i.e. right click on a capsule and select UMLRealTime > Port. Then I select and existing protocol in the dialog Edit dialog that pops up. The problem is that this dialog indicates that the port has already been created. The title of the dialog says "Edit portX" (where X is next availble number). But since the port shall be named according to its selected protocol, the name of any "temporary" port, prior to naming it according to the selected protocol (but with initial small letter) cannot be shown in the title of the dialog. And even after selecting a protocol, the port does not get renamed according to the selected protocol. Maybe the creation (and naming) of a port when being created using the new child menu needs to be done in a different way, especially considering the needs expressed in Bug 477730, where also the system protocols should be available for easy selection. still valid for 1.0.0 I have a solution in progress (seemed not to be assigned to anyone and I have been working on port and capsule-part creation scenarios recently). New Gerrit change created: https://git.eclipse.org/r/71955 Gerrit change https://git.eclipse.org/r/71955 was merged to [master]. Commit: http://git.eclipse.org/c/papyrus-rt/org.eclipse.papyrus-rt.git/commit/?id=c08a1afb207370fb97552e9968e2a04483be43ea (In reply to Eclipse Genie from comment #7) > Gerrit change https://git.eclipse.org/r/71955 was merged to [master]. The default names of ports and capsule-parts are now always their protocol/capsule type name with initial lower case. In the event that any property of the same name is defined by the capsule, these default names are disambiguated with "2", "3", etc. suffixes as necessary. Verified in the latest Papyrus-RT build that the default naming now works as expected for all the different cases of creating capsule parts and ports: Using the new child menu, drag-and-drop and the creation tool on the palette in the capsule structure diagram. Also checked that a unique suffix is added in case of possible name clashes, i.e. creating a port or capsule part typed by the same type as an existing port/capsule part. Closing as verified fixed. |