Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 474242

Summary:	org.eclipse.ui.IMemento.getChildren() is missing
Product:	[RT] RAP	Reporter:	Wolfgang Pedot <wolfgang.pedot>
Component:	Workbench	Assignee:	Project Inbox <rap-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	trivial
Priority:	P3	CC:	ivan
Version:	3.0
Target Milestone:	3.1 M1
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Wolfgang Pedot

2015-08-04 11:25:18 EDT

I recently noticed that getChildren() is missing in org.eclipse.ui.IMemento, according to the JavaDoc header that method was introduced in Eclipse 3.8. The older getChildren(String type) is present.

My guess is that it is rarely used and was simply overlooked or something because looking at the source I can not find a compelling reason why it should not be present in RAP.

I noticed the missing method in 2.3 but confirmed that it is still missing in 3.0.

Comment 1 Ivan Furnadjiev

2015-08-04 11:41:12 EDT

RAP workbench code is still based on 3.7. Could you provide a Gerrit change about it?

Comment 2 Wolfgang Pedot

2015-08-04 12:00:29 EDT

Never done that before...

Comment 3 Ivan Furnadjiev

2015-08-05 04:04:05 EDT

1. You must sign your CLA [1] before we can accept your contribution. Could you please follow the steps in [2]? 
2. Provide the fix as a Gerrit [3] change against master. You can find the Gerrit web UI at [4].

[1] https://wiki.eclipse.org/CLA
[2] https://wiki.eclipse.org/Development_Resources/Contributing_via_Git#Eclipse_Foundation_Contributor_License_Agreement
[3] https://wiki.eclipse.org/Development_Resources/Contributing_via_Git#via_Gerrit
[4] https://git.eclipse.org/r/#/q/project:rap/org.eclipse.rap

Comment 4 Ivan Furnadjiev

2015-08-05 11:05:46 EDT

Platform commit for backporting: https://git.eclipse.org/c/platform/eclipse.platform.ui.git/diff/?h=R3_8_maintenance&id=f2ad59b30122628e116e6c100acf09296dce32f3

Comment 5 Wolfgang Pedot

2015-08-06 11:55:11 EDT

Sorry I have not yet had time to check the CLA and stuff, do you still need me to provide a Gerrit change?

Comment 6 Ivan Furnadjiev

2015-08-09 09:12:36 EDT

(In reply to Wolfgang Pedot from comment #5)
> Sorry I have not yet had time to check the CLA and stuff, do you still need
> me to provide a Gerrit change?

Not for this change. The issue is already fixed in master with change https://git.eclipse.org/r/#/c/53333/.