Bugzilla – Full Text Bug Listing
| Summary: | TypeError: b.hrefCallback is not a function (in navigatorRenderer.js) | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Grant Gayed <grant_gayed> |
| Component: | Client | Assignee: | Michael Rennie <Michael_Rennie> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | Michael_Rennie |
| Version: | 10.0 | ||
| Target Milestone: | 10.0 | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Whiteboard: | |||
This needed a check to see if hrefCallback is a function: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=207ac1b1f2ec73fb7daf24cd616776775eaa910a The API doc in commands states that the function is optional, so I did a pass over orion and updated or added checks for it: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=ad5670f06271565eb7a363ae516e9393713bfd3c |
Our uncaught error logging indicates a problem in the navigatorRenderer.js line marked below: var openWithCommand = mExtensionCommands.getOpenWithCommand(commandService, item, openWithCommands); if (openWithCommand) { href = openWithCommand.hrefCallback({items: item}); // <----- } openWithCommand is resolving to a truthy value but does not have function "hrefCallback()". This has happened for 17 unique users over the last 5 days across various supported browser types.