Bugzilla – Full Text Bug Listing
| Summary: | Update prereqs for Mars.2 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [WebTools] WTP Releng | Reporter: | Harald Albers <eclipse> | ||||
| Component: | releng | Assignee: | Vaninder Rajput <vaninder> | ||||
| Status: | CLOSED FIXED | QA Contact: | Carl Anderson <ccc> | ||||
| Severity: | blocker | ||||||
| Priority: | P3 | CC: | cbridgha, ccc, david_williams, deboer, dimitar.giormov, marcelopllanosc, max, naci.dai, neil.hauge, petya.sabeva, prog85, raghunathan.srinivasan, rpofuk, vaninder | ||||
| Version: | unspecified | Flags: | neil.hauge:
pmc_approved+
petya.sabeva: pmc_approved? (david_williams) petya.sabeva: pmc_approved? (cbridgha) petya.sabeva: pmc_approved? (raghunathan.srinivasan) petya.sabeva: pmc_approved? (naci.dai) ccc: pmc_approved+ |
||||
| Target Milestone: | --- | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| See Also: | https://bugs.eclipse.org/bugs/show_bug.cgi?id=472451 | ||||||
| Whiteboard: | PMC_Approved | ||||||
| Attachments: |
|
||||||
|
Description
Harald Albers
Update for Mars.1 Same behaviour as with Mars. The involved feature versions are slightly differnt: JPA Diagram Editor 1.2.101.v201501141513 default Graphiti 0.12.1.v20150916-0905 Affects me too. The cause it deprecation of IDiagramEditor http://help.eclipse.org/kepler/index.jsp?topic=%2Forg.eclipse.graphiti.doc%2Fjavadoc%2Fdeprecated-list.html Hi, basically the issue is that JPA Diagram editor is build against really old version of graphiti. I tried to update the dependencies, so hopefully this should solve the issue: https://github.com/dgiormov/debtools.dali.jpa.editor.fix Install Graphiti 0.11.4.v20150701-1432 from http://download.eclipse.org/graphiti/updates/0.11.4 It does work , but you must select all packages. I rebuild diagram editor from latest source and it worked without problem. Prepared fix: https://github.com/psabeva/R3_5_maintenance/commit/bbdb4977a4f370f1a41c1c1d1c17be233f69d7b3 It's definitely a stop-ship defect. The diagram editor cannot be opened. There is a workaround - to download the previous version of Graphiti. The fix was tested manually and all the existing JUnit tests are passing successfully. The reason for not opening a diagram editor is the too old dependencies to Graphiti. In Graphiti 0.10.x version, there is a deprecated interface, which is deleted in 0.12.x version. Because we are referring to Graphiti 0.10.x version, the jpa diagram editor project is build with that interface. Because the refences to the old interface are removed long ago, the change requires some of the update sites in the org.eclipse.jpt.jpadiagrameditor.releng pom.xml to be updated to point to the latest eclipse Mars versions. The risk is very low. Carl...Are any other changes required on the WTP build side needed to pull in these updated dependencies? It seems like we would need higher level changes to get the correct dependency versions. Tran used to keep these dependencies up to date. For the build, we point at: <graphiti-repo.url>http://download.eclipse.org/graphiti/updates/milestones</graphiti-repo.url> It looks like we are building against the 0.13.0 driver for Mars.2. So this is just an issue with the Graphiti link in the dependencies section, right? We are going to use this bug to update all of our dependencies for WTP 3.7.2 for Mars.2 Forgot to update feature pom.xml version. Here is the updated github patch https://github.com/psabeva/R3_5_maintenance/commit/165526bcbf3abaaf5134956ba96bc5c174a937fe Hi guys, last week I had some difficulties to push the changes. Finally, I resolved my git issues, so should I wait for another pmc approval or I can push the changes to R3_5_maintenance branch? (In reply to Petya Sabeva from comment #12) > Hi guys, > > last week I had some difficulties to push the changes. Finally, I resolved > my git issues, so should I wait for another pmc approval or I can push the > changes to R3_5_maintenance branch? Petya, Please commit your patch for RC4, using this bug. (In reply to Carl Anderson from comment #13) > (In reply to Petya Sabeva from comment #12) > > Hi guys, > > > > last week I had some difficulties to push the changes. Finally, I resolved > > my git issues, so should I wait for another pmc approval or I can push the > > changes to R3_5_maintenance branch? > > Petya, > > Please commit your patch for RC4, using this bug. Actually, I checked the Simultaneous Release Calendar and noticed that on Tuesday two pmc reviews are required for RC3, so I pushed my changes yesterday... Shall I revert them now? Should be fine to leave them in unless Carl says otherwise. With Mars.2, the situation got slightly worse: Mars.2 includes WTP 3.7.2 with JPA Diagram Editor 1.2.201.v201602090909, which will pull in Graphiti 0.12.2.v20160120-1255. The JPA Diagram Editor is not functional, [Caused by: java.lang.ClassNotFoundException: org.eclipse.graphiti.platform.IDiagramEditor], see inital bug report above for details. The workaround is harder to apply, though because the most recent JPA Diagram Editor (1.2.201.v201602090909) will not install over Graphiti 0.12.2.v20160120-1255. So the workaround now is use old versions of both Graphiti and WTP: 1. Install Eclipse 4.5.2 2. Install Graphiti 0.11.4.v20150701-1432 from http://download.eclipse.org/graphiti/updates/0.11.4 3. Install JPA Diagram Editor 1.2.101.v201501141513 from WTP 3.7.1 update:
> The workaround is harder to apply, though because the most recent JPA Diagram
> Editor (1.2.201.v201602090909) will not install over Graphiti 0.12.2.v20160120-
> 1255.
Should be Graphiti 0.11.4.v20150701-1432.
Will this be fixed in Neon? In Neon, the problem is fixed. I verfied by - installing eclipse-jee-neon-R-win32-x86_64.zip on a vanilla Windows VM - adding JPA Diagram Editor 1.2.300.v201604110621 from http://download.eclipse.org/releases/neon, which pulled in Graphiti 0.13.0.v20160608-1043 - creating a JPA project - opening the JPA Diagram Editor on the JPA project. The JPA Diagram Editor opened as expected. Thanks for fixing. As far as I am concerned, this bug can be closed. Thanks for verifying |