Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 472649

Summary:	Remove getContents() callback from FXView and FXEditor.
Product:	[Tools] GEF	Reporter:	Alexander Nyßen <nyssen>
Component:	GEF MVC	Assignee:	Alexander Nyßen <nyssen>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	0.1.0
Target Milestone:	3.10.1 (Mars SR1) M2
Hardware:	All
OS:	All
Whiteboard:

Description Alexander Nyßen

2015-07-14 14:22:01 EDT

Instead of requesting that viewer contents is provided by means of a callback, we should rather leave to clients when and how the contents of the FXViewer(s) get populated.

Comment 1 Alexander Nyßen

2015-07-25 10:34:21 EDT

Changed that FXView and FXEditor subclasses are now completely responsible of populating their viewers. There is no lifecycle method ensuring this any more:
- Removed getContents() from FXView and FXEditor
- Removd populateViewers() from FXView and FXEditor

Furthermore, FXView and FXEditor now properly unregister the selection provider. Introduced hook methods for activation, deactivation and for unhooking the viewers to FXView and FXEditor (activate(), deactivate(), unhookViewers()). Thereby, clients can now better overwrite and adopt.

Adopted ZestFxUiView and MvcLogoExampleView to the applied changes in FXView. Added missing dependencies to mvc.examples.logo.ui and increased version to 0.1.1.

Pushed changes to origin/master. Resolving as fixed in 3.10.1 M2.