Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 472093

Summary:	ArrayIndexOutOfBoundsException using git page
Product:	[ECD] Orion	Reporter:	John Arthorne <john.arthorne>
Component:	Git	Assignee:	John Arthorne <john.arthorne>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	unspecified
Target Milestone:	10.0
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description John Arthorne

2015-07-07 15:09:02 EDT

Report from a user:

I was working on the Git page and when I clicked on "view the tree for this commit icon" I'm getting the following error message in the pop-up window.


</style> </head> <body> <div id="content"> <div id="page"> <div id="box"> <div id="error"> Exception thrown by application class 'org.eclipse.orion.server.git.servlets.GitHandlerV1.handleRequest:78' </div> <div id="code"> java.lang.ArrayIndexOutOfBoundsException: <br> <div id="stack">at org.eclipse.orion.server.git.servlets.GitHandlerV1.handleRequest(GitHandlerV1.java:78)<br>at org.eclipse.orion.server.git.servlets.GitHandlerV1.handleRequest(GitHandlerV1.java:1)<br>at org.eclipse.orion.server.git.servlets.ServletGitHandler.handleRequest(ServletGitHandler.java:51)<br>at org.eclipse.orion.server.git.servlets.ServletGitHandler.handleRequest(ServletGitHandler.java:1)<br>at org.eclipse.orion.server.git.servlets.GitServlet.doGet(GitServlet.java:41)<br>at javax.servlet.http.HttpServlet.service(HttpServlet.java:575)<br>at javax.servlet.http.HttpServlet.service(HttpServlet.java:668)<br>at org.eclipse.equinox.http.registry.internal.ServletManager$ServletWrapper.service(ServletManager.java:180)<br>at org.eclipse.equinox.http.servlet.internal.ServletRegistration.service(ServletRegistration.java:61)<br>a

Comment 1 John Arthorne

2015-07-07 15:38:48 EDT

Released a simple fix to reject such invalid requests:

http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=bd0778e5cf940f11d4ef5dd43457854219d38c48