Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 472051

Summary:	Under Windows, changing the diagram selection makes the tabbar redraw visible
Product:	[Modeling] Sirius	Reporter:	Pierre-Charles David <pierre-charles.david>
Component:	Diagram	Assignee:	Laurent Redor <laurent.redor>
Status:	CLOSED FIXED	QA Contact:	Laurent Redor <laurent.redor>
Severity:	major
Priority:	P2	CC:	laurent.redor, maxime.porhel
Version:	3.0.0	Keywords:	triaged
Target Milestone:	4.0.0M7
Hardware:	PC
OS:	Windows All
See Also:	https://git.eclipse.org/r/69402 https://git.eclipse.org/r/69435 https://git.eclipse.org/r/69880 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=d2565e229e0b822e061beab83159c96394f31462 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=2654f2c8594a2cd0ea94a28decaa6dacd3c926a1
Whiteboard:
Bug Depends on:
Bug Blocks:	491173

Description Pierre-Charles David

2015-07-07 09:03:44 EDT

It seems this is only visible under Windows. If present under Linux and/or Mac, the effect can not be distinguished visually.

Steps to reproduce:
1. Open a diagram with at least one element inside.
2. Select alternatively the diagram or the element.

On each selection change, the content of the tabbar changes (which is expected), but under Windows the content change seems so slow that it produces an unintended "animation" effect, which is visually distracting.

Comment 1 Laurent Fasani

2016-02-23 09:35:08 EST

Proposal to fix this bug is to let sirius manage the visibility of the IContributionItem instead of eclipse.

Actually, the "animation" effect won't be fix but the visibility change will quick enough to reach an acceptable state.

As it is done with TabbarFillerWithContributor the item are provided staticly.
We let eclipse manage the visibility only for items contributed through org.eclipse.ui.menus extension point.(locationURI=toolbar:org.eclipse.sirius.diagram.ui.tabbar)

We could remove TabbarFillerWithoutContributions and TabbarFillerWithContributions and enhance TabbarFillerWithContributor to manage the case where there is no ITabbarContributor. In that case, dofill method instanciate a DefaultTabbbarContributorImpl and add the items contributed with org.eclipse.ui.menus extension point.
All the sirius item staticly added are not declared as org.eclipse.ui.menus any more.

Comment 2 Eclipse Genie

2016-03-29 09:53:08 EDT

New Gerrit change created: https://git.eclipse.org/r/69435

Comment 3 Eclipse Genie

2016-04-05 04:04:22 EDT

New Gerrit change created: https://git.eclipse.org/r/69880

Comment 4 Eclipse Genie

2016-04-07 05:53:41 EDT

Gerrit change https://git.eclipse.org/r/69435 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=d2565e229e0b822e061beab83159c96394f31462

Comment 5 Eclipse Genie

2016-04-07 05:53:45 EDT

Gerrit change https://git.eclipse.org/r/69402 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=2654f2c8594a2cd0ea94a28decaa6dacd3c926a1

Comment 6 Laurent Redor

2016-04-07 05:58:25 EDT

Fixed with 2 above commits.

Comment 7 Laurent Redor

2016-05-26 08:38:48 EDT

Verified on Sirius 4.0.0 RC1 (4.0.0.201605180923)

Comment 8 Pierre-Charles David

2016-06-24 08:01:01 EDT

Available in Sirius 4.0.0.