Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 472036

Summary: Improve the Region/RegionContainer policies to allow recursive regions
Product: [Modeling] Sirius Reporter: Maxime Porhel <maxime.porhel>
Component: DiagramAssignee: Maxime Porhel <maxime.porhel>
Status: CLOSED FIXED QA Contact:
Severity: enhancement    
Priority: P1 CC: florian.barbin, pierre-charles.david
Version: 3.0.0Keywords: triaged
Target Milestone: 3.1.0   
Hardware: All   
OS: All   
See Also: https://git.eclipse.org/r/54211
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=93819d4d6e6f19c039f9e03d3ad9ae37af21be94
https://git.eclipse.org/r/54279
https://git.eclipse.org/r/54303
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=ef5371f3061d69b2ebf67e7b8b36ab1857ea59e8
https://git.eclipse.org/r/56144
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=92b96cbbc73ebf2b9af5b194ec849b44cb5791cb
Whiteboard: needtest
Bug Depends on:    
Bug Blocks: 470859    
Attachments:
Description Flags
Sample with recursive regions none

Description Maxime Porhel CLA 2015-07-07 05:45:54 EDT 
Compartment support is currently limited to a single depth level: a container mapping B can be contained in a container mapping A with children presentation set to horizontal/vertical stack but can only have its own children presentation set to FreeFrom or List. --> B can be a Region but not a RegionContainer. 

The property section has been customized to forget this and a validation rule have also been added. Specifier can still force it (manually set the value in a text editor): the  figure initialization will be ok, but there is no guarantee around the resize and other user interactions done on the regions which are also region containers.

The idea of the bug is to enhance the policies to allow the recursive regions and then to remove the guards in the VSM editor.
Comment 1 Maxime Porhel CLA 2015-08-17 03:47:31 EDT 
Created attachment 255883 [details]
Sample with recursive regions
Comment 2 Eclipse Genie CLA 2015-08-20 06:01:41 EDT 
New Gerrit change created: https://git.eclipse.org/r/54211
Comment 4 Eclipse Genie CLA 2015-08-21 04:31:52 EDT 
New Gerrit change created: https://git.eclipse.org/r/54279
Comment 5 Eclipse Genie CLA 2015-08-21 09:31:46 EDT 
New Gerrit change created: https://git.eclipse.org/r/54303
Comment 7 Eclipse Genie CLA 2015-09-17 05:12:00 EDT 
New Gerrit change created: https://git.eclipse.org/r/56144
Comment 9 Maxime Porhel CLA 2015-10-13 09:26:00 EDT 
Validation can be done using the compartment junit data test located in org.eclipse.sirius.tests.junit/data/unit/compartments

Open the RegionsInRegions diagram
Play with the resize
Check that collapse, hide, make same size actions are not enabled
Modify the model and check that the diagram is well (de)populated
You can also add some creation tools.
Comment 10 Florian Barbin CLA 2015-10-14 11:48:57 EDT 
Verified on Sirius 3.1.0.201510140809
Comment 11 Pierre-Charles David CLA 2015-10-16 09:11:36 EDT 
Available in Sirius 3.1.0.