Bugzilla – Full Text Bug Listing
|
Description
Maxime Porhel
Do not forget to remove the ContainerMappingChildrenPresentationConstraints.REGION_REGION_CONTAINER_MAPPING_STYLE_RULE_ID constraint once the image support will be completed. Fist found issue: the Regions are not well located in their RegionContainer when it has a WorkspaceImageDescription: the insets of the content pane seem to be misconfigured. New Gerrit change created: https://git.eclipse.org/r/54409 New Gerrit change created: https://git.eclipse.org/r/54408 New Gerrit change created: https://git.eclipse.org/r/54416 Additional issues corrected by the current:
. the border size/color changes are managed only for the FlatContainerStyleDescription
-> https://git.eclipse.org/r/#/c/54408/
. the image needs improvements when workspacePath is or becomes empty to be consistent with the part creation, in the same code area: the gradient style changes are handled only for the freeform DNodeContainer but not for the DNodeList and Regions
-> https://git.eclipse.org/r/#/c/54409/
. the corner refresh needs to be update to handle preceding/following regions which does not necessarily support corners (e.g. WorkspaceImage)
-> https://git.eclipse.org/r/#/c/54416/
Gerrit change https://git.eclipse.org/r/54409 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=272e69bb35772e3a51c6d7554a6cfe7a8d6d0aa9 Gerrit change https://git.eclipse.org/r/54408 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=9a545eb3151581530d4285a3738dd9976a76c459 New Gerrit change created: https://git.eclipse.org/r/54565 New Gerrit change created: https://git.eclipse.org/r/54571 New Gerrit change created: https://git.eclipse.org/r/54601 New Gerrit change created: https://git.eclipse.org/r/54660 Gerrit change https://git.eclipse.org/r/54416 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=313416a5257555eddb1d62e1ba6412af68b36d28 Gerrit change https://git.eclipse.org/r/54571 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=69d9e9b4e4da54c7f62b783036719ce42f3c5056 Gerrit change https://git.eclipse.org/r/54601 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=76e801508e7452982cb4efdba9bcd8b37c5cc8d9 Gerrit change https://git.eclipse.org/r/54660 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=0b09358624894ac60e5cdcf325a41d44e831f9e0 Gerrit change https://git.eclipse.org/r/54565 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=56f29a9696845fdbad9742f15d4c5fdf57fdebb5 Validation can be done using the compartment junit data test located in org.eclipse.sirius.tests.junit/data/unit/compartments Create a project named DesignerTestProject and paste the data in it. Open ImageDiag (it allows to check the behavior withimage styles defined in the VSM) Check that image (Regions and RegionContainer) are displayed but also the VSM defined borders. Check that you can use the tabbar button to change the image and then reset the style. Open the VStackDiag (and then the HStackDiag), change the styles of Regions and RegionContainers to an image and then reset the style. No error should be thrown (or printed in the console) and each step should produce a consistent diagram and layout. Verified on Sirius 3.1.0.201510140809 Available in Sirius 3.1.0. |