Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 471901

Summary:	Android Common XML Editor should not be the default for all XML files
Product:	[Tools] andmore	Reporter:	Kaloyan Raev <kaloyan>
Component:	Core	Assignee:	David Carver <d_a_carver>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	cdtdoug, d_a_carver
Version:	unspecified
Target Milestone:	0.5-M2
Hardware:	PC
OS:	Linux
See Also:	https://github.com/eclipse/andmore/pull/94
Whiteboard:

Description Kaloyan Raev

2015-07-06 05:21:28 EDT

The Android Common XML Editor is declared as the default for all XML files. This does not play nice with other XML editors contributed by other plugins.

For example if I have Andmore and PDE installed together, then the plugin.xml of a Eclipse plugin project is opened by default with the Android Common XML Editor instead of with the PDE Manifest Editor. Moreover, the Android Common XML Editor breaks when opening the plugin.xml file.

I do not notice any drawback if I change the declaration of the Android Common XML Editor to have default=false. The XML files in Android projects are still opened with this editor by default, but the plugin.xml is now opened with the PDE Manifest Editor by default - as expected.

Comment 1 Eclipse Genie

2015-07-06 05:25:02 EDT

GitHub Pull Request 94 created by [kaloyan-raev]
https://github.com/eclipse/andmore/pull/94

Comment 2 David Carver

2015-07-07 17:31:49 EDT

Will merge this change in as soon.  Sorry for the delay.

Comment 3 David Carver

2015-07-08 11:01:34 EDT

Merged this into develop.  Thanks for the fix, it has been a long annoying bug.

Comment 4 Doug Schaefer

2015-07-08 12:44:06 EDT

Actually, it looks like this was merged to master, not develop. Just did a pull.

Comment 5 Kaloyan Raev

2015-07-08 12:47:21 EDT

Can anyone enlightened me why there is develop and master branches and what is the difference between them? Perhaps, it makes sense to describe this in the Contributing section of the README.

Comment 6 David Carver

2015-07-08 12:51:22 EDT

(In reply to Kaloyan Raev from comment #5)
> Can anyone enlightened me why there is develop and master branches and what
> is the difference between them? Perhaps, it makes sense to describe this in
> the Contributing section of the README.

I'm following the gitflow model for development:

http://nvie.com/posts/a-successful-git-branching-model/

When a milestone is released, it is merged into the "master" branch and tagged, master is what is considered to be stable code.

The development branch is where the active development happens, when it is considered read to release a milestone and an official release, a release branch will be cut, built, tagged, and then once it is considered good, it'll be merged back into master.

Comment 7 David Carver

2015-07-08 12:52:06 EDT

A bit more information is available on the wiki for the project.

https://github.com/eclipse/andmore/wiki/Releasing-Andmore

Comment 8 David Carver

2015-07-08 12:55:28 EDT

(In reply to Doug Schaefer from comment #4)
> Actually, it looks like this was merged to master, not develop. Just did a
> pull.

Thanks Doug.  I've pulled the change over into develop and pushed it to the github repo.

Comment 9 Kaloyan Raev

2015-07-08 12:58:37 EDT

(In reply to David Carver from comment #6)
> When a milestone is released, it is merged into the "master" branch and
> tagged, master is what is considered to be stable code.

I supposed it was gitflow... I've always wondered what is the benefit of using master just for tags log... Nevermind, your choice...

Since most of the Eclipse projects expect contributions to be done in the master branch, it should be clearly stated that Andmore expects them in the develop branch. Currently, this is not clear in the README file - the info is buried in the wiki.

Comment 10 Doug Schaefer

2015-07-08 12:59:48 EDT

(In reply to David Carver from comment #8)
> (In reply to Doug Schaefer from comment #4)
> > Actually, it looks like this was merged to master, not develop. Just did a
> > pull.
> 
> Thanks Doug.  I've pulled the change over into develop and pushed it to the
> github repo.

Got it. Thanks!

Comment 11 Kaloyan Raev

2015-07-09 04:34:08 EDT

Verified with the latest nightly build.

Comment 12 David Carver

2015-08-09 21:12:41 EDT

*** Bug 465702 has been marked as a duplicate of this bug. ***