Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 471875

Summary:

[IconExe] Improve error message when launcher's icons has not been replaced

Product:

[Eclipse Project] Equinox

Reporter:

Mykola Nikishov <mn>

Component:

Assignee:

P2 Inbox <equinox.p2-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

enhancement

Priority:

CC:

pascal

Version:

unspecified

Target Milestone:

Neon M7

Hardware:

All

OS:

All

See Also:

https://git.eclipse.org/r/18524
https://git.eclipse.org/r/18525
https://git.eclipse.org/c/equinox/rt.equinox.p2.git/commit/?id=b1b3edccf441e5b5edf90e4c9cc08acf6d197f92

Whiteboard:

Bug Depends on:

488579

Bug Blocks:

Attachments:

Description	Flags
.ICO with wrong icons in #5, #6 and #7	none

Description Mykola Nikishov

2015-07-05 18:10:26 EDT

Created attachment 254955 [details]
.ICO with wrong icons in #5, #6 and #7

Branding an Eclipse-based product, when targeting Windows platforms, requires changing icons embedded into native Windows launcher. Due to non-informative error message and almost no documentation on how to embed custom icons into the launcher, this process is error-prone and hard to debug [1], [2], [3].

IconExe's log messages could be improved to provide more information.

[1] https://stackoverflow.com/questions/10999323/error-in-tycho-while-replacing-the-product-ico-files
[2] https://issues.jboss.org/browse/JBDS-3078
[3] https://dev.eclipse.org/mhonarc/lists/tycho-user/msg00362.html
[4] https://github.com/neo4j-contrib/neoclipse/commit/2c0034cefcb4bc87afbc68d2c0e90ffdd8852d6c

Comment 1 Eclipse Genie

2016-04-20 23:17:27 EDT

Gerrit change https://git.eclipse.org/r/18524 was merged to [master].
Commit: http://git.eclipse.org/c/equinox/rt.equinox.p2.git/commit/?id=b1b3edccf441e5b5edf90e4c9cc08acf6d197f92

Comment 2 Pascal Rapicault

2016-04-20 23:18:37 EDT

Thanks for the contribution and sorry for the delay on this.