Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 471833

Summary: up/down buttons for search results should scroll in the file when pressed
Product: [ECD] Orion Reporter: Steve Northover <steve_northover>
Component: ClientAssignee: libing wang <libingw>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: Carolyn_MacLeod, libingw, Silenio_Quarti
Version: unspecified   
Target Milestone: 15.0   
Hardware: PC   
OS: Windows 7   
See Also: https://git.eclipse.org/r/88195
https://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=b201361e19ee92ea8a940a8a0c0a0529263f81b5
Whiteboard:

Description Steve Northover CLA 2015-07-03 14:52:24 EDT 
1) Edit->Global Search
2) Type in 'ProjectJsonLocation' or string that will be found
3) Use arrow keys to move through the results
4) BUG/UNWANTED BEHAVIOR:  When I press the up/down buttons, I should scroll in the file

I can't think of a case where I would want to arrow around and not scroll in the file. I suppose if I was using the arrow keys to get to an item and then get it's contents.

Really, we should move a focus rectangle if we are doing this, not the selection but I would be happy if the scrolling just happened and we could address the focus rectangle idea elsewhere.
Comment 1 Carolyn MacLeod CLA 2015-07-07 17:58:35 EDT 
I assume you mean "arrow buttons" (aka "magic fingers") and not "arrow keys".

An accessibility problem is that the arrow keys (i.e. on the keyboard) do not work at all in this scenario. This should be fixed as well.

I agree that the up/down arrow buttons should open the selected file (if not already open) and scroll to the selected search result location in that file.
Comment 2 Eclipse Genie CLA 2017-01-06 13:26:00 EST 
New Gerrit change created: https://git.eclipse.org/r/88195
Comment 4 libing wang CLA 2017-04-20 16:26:01 EDT 
fixed.