Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 471816

Summary:

Reconnect target point of rectilinear edge can move the source point of edge

Product:

[Modeling] Sirius

Reporter:

Laurent Redor <laurent.redor>

Component:

Diagram

Assignee:

Project Inbox <sirius.diagram-inbox>

Status:

CLOSED FIXED

QA Contact:

Jessy Mallet <jessy.mallet>

Severity:

normal

Priority:

CC:

belqassim.djafer, florian.barbin, jessy.mallet, maxime.porhel

Version:

3.0.0

Keywords:

triaged

Target Milestone:

3.1.0

Hardware:

OS:

Linux

See Also:

https://git.eclipse.org/r/51339
https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/51339
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=fa07a218e1348571c049ba7a3f87d48e73259504

Whiteboard:

Attachments:

Description	Flags
Screenshot to show the issue.	none

Description Laurent Redor

2015-07-03 10:28:23 EDT

When the target point, of a rectilinear edge, is reconnected, the source point is, in some circumstance, also moved and a new bendpoint is created.

A test will be added in gerrit to reveal the problem.

Comment 1 Eclipse Genie

2015-07-03 10:30:25 EDT

New Gerrit change created: https://git.eclipse.org/r/51339

Comment 2 Laurent Redor

2015-07-03 10:33:39 EDT

The test in gerrit of comment 1 reveals the problem (warning the failing of the method testEdgeWithPortSourceDnDWithObliqueStyleRouting does not concern this bug, but the bug 471814).

Comment 3 Maxime Porhel

2015-07-06 05:43:59 EDT

Created attachment 254969 [details]
Screenshot to show the issue.

Steps to reproduce: 
 . open the diagram called "new DiagramForBug467663WithRectilinear" from /org.eclipse.sirius.tests.swtbot/data/unit/edgeReconnection
 . Reconnect the first edge from EClass1 to EClass2
 . Reconnect the edge from EClass2 to EClass 1: the source moved and a new segment has been created.

Comment 4 Belqassim Djafer

2015-07-09 11:23:34 EDT

This issue also exists in Sirius 2.0 and 1.0.1

Comment 5 Florian Barbin

2015-09-09 11:41:04 EDT

This issue was caused by the same issue than 471814. The 471814 resolution fixes this bug.

Comment 6 Florian Barbin

2015-09-10 03:16:53 EDT

Fixed by 471814

Comment 7 Jessy Mallet

2015-09-28 12:33:58 EDT

Validated with Sirius 3.1.0.201509241504

Comment 8 Pierre-Charles David

2015-10-16 09:12:53 EDT

Available in Sirius 3.1.0.

Comment 9 Eclipse Genie

2022-07-20 10:19:15 EDT

Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/51339 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=fa07a218e1348571c049ba7a3f87d48e73259504