Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 471628

Summary: Ensure feedback can be adjusted in a more lightweight manner
Product: [Tools] GEF Reporter: Alexander Nyßen <nyssen>
Component: GEF MVCAssignee: Matthias Wienand <matthias.wienand>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: matthias.wienand
Version: 0.1.0   
Target Milestone: 3.10.1 (Mars SR1) M1   
Hardware: All   
OS: All   
Whiteboard:

Description Alexander Nyßen CLA 2015-07-02 01:46:30 EDT 
The FXDefaultFeedbackPartFactory does not obtain the feedback parts it creates via the injector, but creates them directly. We should change this, so different implementations can be bound. Furthermore we should provide feedback effects via a provider, so it can easily be exchanged without having to adjust the feedback parts.
Comment 1 Matthias Wienand CLA 2015-07-03 09:44:46 EDT 
I ensured that the feedback parts are obtained via the injector. Furthermore, I added checks for adapters of type Provider<Effect> under various new roles (hover effect, primary focused selection effect, primary unfocused selection effect, secondary focused selection effect, secondary unfocused selection effect) to the hover and selection behaviors. If such an adapter is supported by the host part, then it will be queried for the effect to use. The code is published on the master branch, therefore, I resolve this ticket as fixed for 3.10.1M1.