Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 471016

Summary:	Build failure in https://hudson.eclipse.org/orion/job/orion-client-dev/872/ (no WeakMap)
Product:	[ECD] Orion	Reporter:	Michael Rennie <Michael_Rennie>
Component:	JS Tools	Assignee:	Michael Rennie <Michael_Rennie>
Status:	RESOLVED FIXED	QA Contact:
Severity:	major
Priority:	P3	CC:	john.arthorne, mamacdon, Silenio_Quarti, simon_kaegi
Version:	9.0
Target Milestone:	10.0
Hardware:	All
OS:	All
Whiteboard:

Description Michael Rennie

2015-06-25 10:47:44 EDT

The build failed because we are using an ES6 class (WeakMap) via a third party lib (escope 2.0.4):

https://hudson.eclipse.org/orion/job/orion-client-dev/lastCompletedBuild/testReport/TEST_http___orion_test_mybluemix_net_80_js_tests_javascript_JsMochaSuite_html_env_integration_9e95d933c7d14852bbfdab9f3b901ddb/xml/SuiteFailure/

WeakMap is supposed to be in all versions of browsers we support, but it looks like we are testing against Safari 7.0 in sauce, which does not have support for WeakMap.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WeakMap#Browser_compatibility

So I can do one of two things:

1. we can bump the min version of safari we test against - but this depends on what versions of Safari we claim to support

2. I can impl WeakMap if its not available

Comment 1 Michael Rennie

2015-06-25 12:48:42 EDT

Running the sauce tests locally I confirmed that to have them pass (keeping the WeakMap ref) we have to update the config to OSC 10.10 and Safari 8.

Is bumping the min version that Orion supports to Safari 8+ something we want to do? In theory WeakMap should work just fine in Safari 7.1+ on OSX 10.9.5+, but I don't have that setup to test on.

Comment 2 Michael Rennie

2015-06-25 14:45:32 EDT

Grant pushed an update to the test config:

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=99414405de07722e3aa3146f15c3878de518bdd5

that will allow the tests to pass, but will mask the problem that Orion will not run on anything older than Safari 7.1+

Comment 3 Michael Rennie

2015-08-06 12:49:22 EDT

Closing as fixed. We updated the test config, so no other changes are needed.