Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 470985

Summary:	File name search: Should be able to scope file name search.
Product:	[ECD] Orion	Reporter:	libing wang <libingw>
Component:	Client	Assignee:	Eric Moffatt <emoffatt>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	Silenio_Quarti, snorthov
Version:	9.0
Target Milestone:	10.0
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description libing wang

2015-06-25 08:13:51 EDT

Currently file name search(CTRL+SHIFT+F) searches the whole work space no matter which project you are in. This is useful in some cases but search will take long time and may timeout if you have a huge work space. Bug 470724 comment 10 addressed this timeout issue and will fix it.
However we may want to give user an option in the file name find dialog to scope the search. There are two choices:
1. When user is inside a project or a project is selected in the edit page, we will use a check box, say, "find files in the current folder". It will be default to true if user has not yet check/uncheck the flag.

2. When user is inside a project or a project is selected in the edit page, we will use a folder selection widget, like the content search pane does.

As CTRL+SHIFT+F can be triggered in any page, we should also consider the pages where we can not find a scope. We may then want choice 2.

Comment 1 Eric Moffatt

2015-07-03 15:07:14 EDT

OK, here's a commit that will allow scoping the search between either the current project or 'all' projects. We'll continue to look to see whether more fine grained scoping is necessary...

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=f728db3446a4dacb99e7c66b80a5dd96a4754070

Comment 2 Eric Moffatt

2015-07-06 15:53:33 EDT

Two tweaks:

This one removes the FileMap approach since it was interfering with 'normal' tooling flows (i.e. they were broken)

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=2aa49b8d383ddcc915cb5bbc8ce0608530778cc3

This one just captures metrics whenever the user changes the check box on the dialog(s).

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=081f41b71f508bf01eec2b52af4ce2bfa6e4cf12

Comment 3 John Arthorne

2015-07-28 16:31:26 EDT

Can this be marked fixed?

Comment 4 libing wang

2015-08-19 10:34:18 EDT

I think it is fixed.