Bug 470810

Description Rudolf Mayer 2015-06-23 10:42:22 EDT

When using a try-with-resources statement in the to-be extracted code that depends on a previously defined local variable, this variable is not created as parameter in the new method. Example:


public class ExtractMethodError {
    public static void main(String[] args) throws java.io.FileNotFoundException, java.io.IOException {

        String file = "/tmp/test.txt";
        try (java.io.FileInputStream inputStream = new java.io.FileInputStream(file)) {
            System.out.println(inputStream.available());
        }
    }
}

When selecting the part in the try statement and extracting a method, this gets generated:

public class ExtractMethodError {
    public static void main(String[] args) throws java.io.FileNotFoundException, java.io.IOException {

        String file = "/tmp/test.txt";
        extractedMethod();
    }

    public static void extractedMethod() throws java.io.FileNotFoundException, java.io.IOException {
        try (java.io.FileInputStream inputStream = new java.io.FileInputStream(file)) {
            System.out.println(inputStream.available());
        }
    }
}

I.e. "file" is not created as parameter (and also not passed)