Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 470770

Summary:

Rounded corner behavior with compartments

Product:

[Modeling] Sirius

Reporter:

Maxime Porhel <maxime.porhel>

Component:

Diagram

Assignee:

Maxime Porhel <maxime.porhel>

Status:

CLOSED FIXED

QA Contact:

Jessy Mallet <jessy.mallet>

Severity:

normal

Priority:

CC:

jessy.mallet, laurent.fasani, pierre-charles.david

Version:

3.0.0

Keywords:

triaged

Target Milestone:

3.1.0

Hardware:

All

OS:

All

See Also:

Whiteboard:

Bug Depends on:

Bug Blocks:

470859

Attachments:

Description	Flags
RegionContainer with rounded corner and Region without rounded corner	none
Region and RegionContainer with rounded corner	none
Result with first draft correction	none
RoundedCorner improvements on regions	none

Description Maxime Porhel

2015-06-23 04:31:18 EDT

Created attachment 254626 [details]
RegionContainer with rounded corner and Region without rounded corner

Compartments have been introduced in Sirius in bug 436359.

There are a few issues when the rounded corner are enabled in the VSM:

 . If the rounded corner is enabled for the RegionContainer mapping but not on the Region mapping, the corner of the compartment overlap the rounded border of its parent (see attached screenshot)
-> We might improve this case by drawing the last region bottom corners with the same corner dimension (hstack: bottom left/right corner of the first/last region). This might require to modify GradientRoundedRectangle to be able to configure the corner to draw with drawArc.

 . If the rounded corner is enabled for the Region, the border separator is drawn without taking the corner dimension into account. (see attached screenshot)

Comment 1 Maxime Porhel

2015-06-23 04:31:41 EDT

Created attachment 254627 [details]
Region and RegionContainer with rounded corner

Comment 2 Eclipse Genie

2015-06-23 05:41:20 EDT

New Gerrit change created: https://git.eclipse.org/r/50699

Comment 3 Maxime Porhel

2015-06-23 05:45:52 EDT

Created attachment 254631 [details]
Result with first draft correction

Comment 4 Maxime Porhel

2015-06-23 09:51:22 EDT

See https://github.com/ObeoNetwork/UML-Designer/issues/376
See https://github.com/ObeoNetwork/UML-Designer/issues/371

Comment 5 Eclipse Genie

2015-08-07 05:30:55 EDT

Gerrit change https://git.eclipse.org/r/50699 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=d5d1e8629473df6f99be9e7b3a20880353e4879a

Comment 6 Eclipse Genie

2015-08-07 05:31:21 EDT

Gerrit change https://git.eclipse.org/r/50729 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=e3b64dff58c55dc03ad23824a6dca603b474825c

Comment 7 Eclipse Genie

2015-08-07 12:02:56 EDT

New Gerrit change created: https://git.eclipse.org/r/53421

Comment 8 Eclipse Genie

2015-08-10 03:47:01 EDT

Gerrit change https://git.eclipse.org/r/53421 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=a55479375c6d47e65d905b88ec3f868aa016db65

Comment 9 Eclipse Genie

2015-08-10 06:07:40 EDT

New Gerrit change created: https://git.eclipse.org/r/53465

Comment 10 Maxime Porhel

2015-08-10 06:10:50 EDT

Created attachment 255752 [details]
RoundedCorner improvements on regions

Comment 11 Eclipse Genie

2015-08-13 04:16:20 EDT

Gerrit change https://git.eclipse.org/r/53465 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=688f7007c9e5e822122e16a05073c511a771f773

Comment 12 Maxime Porhel

2015-08-17 03:19:35 EDT

Resolved on master

Comment 13 Jessy Mallet

2015-09-28 10:43:09 EDT

Validated with Sirius 3.1.0.201509241504

Comment 14 Pierre-Charles David

2015-10-16 09:10:33 EDT

Available in Sirius 3.1.0.