Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 469767

Summary: [otdre] @ImplicitTeamActivation doesn't work in simple case
Product: [Tools] Objectteams Reporter: Stephan Herrmann <stephan.herrmann>
Component: OTJAssignee: Stephan Herrmann <stephan.herrmann>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: stephan.herrmann
Version: 2.4   
Target Milestone: 2.5 RC   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on:    
Bug Blocks: 484164    

Description Stephan Herrmann CLA 2015-06-09 14:16:27 EDT 
Test org.eclipse.objectteams.otdt.tests.otjld.teamactivation.ImplicitTeamActivation.test5316_implicitActivationAnnotation1() still fails under OTDRE.

Interestingly, the more complex test5316_implicitActivationAnnotation2 passes. Could be an issue of method-annotation vs. role-annotation.
Comment 1 Stephan Herrmann CLA 2016-05-24 17:24:24 EDT 
Resolved via commit f9ffd8cafcf58e1227e4c1dc4d661fc416fd95dc

The issue was caused by inconsistent handling of method visibility (a private team method with @ImplicitTeamActivation was not woven).

While one could argue about usefulness of implicit team activation via a private method, careful reading of OTJLD 5.3(d) visibility is only respected for type-level annotations, not method-level annotations. And silently ignoring the annotation on a private method wouldn't be nice to users.