Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 469761

Summary: [otdre] implement inheritable team activation
Product: [Tools] Objectteams Reporter: Stephan Herrmann <stephan.herrmann>
Component: OTJAssignee: Stephan Herrmann <stephan.herrmann>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: stephan.herrmann
Version: 2.4   
Target Milestone: 2.5.2   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on:    
Bug Blocks: 484164    

Description Stephan Herrmann CLA 2015-06-09 14:04:59 EDT 
Test org.eclipse.objectteams.otdt.tests.otjld.teamactivation.ExplicitTeamActivation.test5218_inheritableTeamActivation1() still fails under OTDRE:

t.setInheritableActivation(true) has no effect
Comment 1 Stephan Herrmann CLA 2016-10-06 13:08:17 EDT 
Analysis: _OT$creationThread was never set in, because we were overriding the wrong hook. With no creation thread, TeamThreadManager.newThreadStarted() cannot detect if the parent thread has the team activated.
Comment 2 Stephan Herrmann CLA 2016-10-06 13:46:12 EDT 
(In reply to Stephan Herrmann from comment #1)
> Analysis: _OT$creationThread was never set in,

insert: in *constructors of Thread / Runnable*.

> because we were overriding the wrong hook. 

Viz. the AdviceAdapter in AddThreadNotificationAdapter.visitMethod() must override visitMethodInsn() not visitConstructor().


Fixed in commit 0f949b15db1190dca0d6644f8deab2d8cd482955

Released for 2.6 M3
Comment 3 Stephan Herrmann CLA 2016-11-22 14:14:01 EST 
Cherry picked for 2.5.2 as commit 3dffdcf7358c5d5884d62f264640d7e7fdaeb533