Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 469478

Summary:	Move JavaFX-unrelated classes from MVC.FX.UI to MVC.UI.
Product:	[Tools] GEF	Reporter:	Matthias Wienand <matthias.wienand>
Component:	GEF MVC	Assignee:	Matthias Wienand <matthias.wienand>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	nyssen
Version:	0.1.0
Target Milestone:	3.10.1 (Mars SR1) M1
Hardware:	All
OS:	All
Whiteboard:

Description Matthias Wienand

2015-06-05 08:39:55 EDT

Currently, MVC.FX.UI provides a DefaultSelectionProvider which is bound within the MvcFxUiModule. However, the DefaultSelectionProvider is unrelated to JavaFX and should therefore be moved to the MVC.UI module, along with its binding.

Comment 1 Matthias Wienand

2015-06-05 09:19:36 EDT

I changed the title, because more classes are JavaFX-unrelated and should, therefore, be moved to MVC.UI:
- FXEditorActionBarContributor, which should also be renamed.
- SelectionForwarder

Comment 2 Matthias Wienand

2015-06-25 06:55:44 EDT

I moved the FXEditorActionBarContributor and DefaultSelectionProvider from MVC.FX.UI to MVC.UI and renamed the FXEditorActionBarContributor to DefaultActionBarContributor. The code is published on the master branch, therefore I resolve this ticket as fixed for 3.10.1M1.

Comment 3 Alexander Nyßen

2015-06-26 12:41:57 EDT

IMHO its ok to move the SelectionProvider, but the FXEditorActionBarContributor is bound to the FXEditor and should remain in its place. I think it does not make sense to move it down to MVC.UI.

Also, as we are targeting a bugfix release for 3.10.1 we should not apply such major API changes now (moving and renaming classes IMHO is a major API change). Could you please revert the changes for 3.10.1?

Comment 4 Matthias Wienand

2015-07-02 09:24:11 EDT

I reverted the moving and renaming of FXEditorActionBarContributor. The code is published to the master branch, therefore, I resolve this ticket as fixed for 3.10.1M1.