Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 469405

Summary:	Mistakes in tab-bar extensions documentation
Product:	[Modeling] Sirius	Reporter:	Maxime Porhel <maxime.porhel>
Component:	Documentation	Assignee:	Projet Inbox <sirius.doc-inbox>
Status:	CLOSED FIXED	QA Contact:
Severity:	minor
Priority:	P3	CC:	pierre-charles.david
Version:	1.0.1	Keywords:	triaged
Target Milestone:	3.0.0
Hardware:	All
OS:	All
See Also:	https://git.eclipse.org/r/49457 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=1d4c46188817982ddbe6a05ba9cfaed0ec41a719
Whiteboard:

Description Maxime Porhel

2015-06-04 10:43:56 EDT

Several mistakes have been detected in the tab-bar extension documentation [1]. 
The error is present since the diagram plugin split into diagram and diagram.ui

<with variable="activeEditorId">
   <equals value="org.eclipse.sirius.diagram.part.SiriusDiagramEditorID"/>
</with>

The Sirius diagram editor id is org.eclipse.sirius.diagram.ui.part.SiriusDiagramEditorID

See also the property tester definitions: shouldActivateTabbarExtensionid= should be replaced by id=

The errors are present on master (3.0.x), 2.0.x and 1.0.x

[1] https://www.eclipse.org/sirius/doc/developer/extensions-provide_tabbar_extensions.html

Comment 1 Eclipse Genie

2015-06-04 11:30:59 EDT

New Gerrit change created: https://git.eclipse.org/r/49457

Comment 2 Eclipse Genie

2015-06-08 04:23:40 EDT

Gerrit change https://git.eclipse.org/r/49457 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=1d4c46188817982ddbe6a05ba9cfaed0ec41a719

Comment 3 Pierre-Charles David

2015-06-08 04:23:55 EDT

Fix merged.

Comment 4 Pierre-Charles David

2015-06-24 11:14:55 EDT

Available in Sirius 3.0.0. See https://wiki.eclipse.org/Sirius/3.0.0.