Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 469043

Summary:	Rename Element (variable) does not work from the menu item
Product:	[ECD] Orion	Reporter:	Steve Northover <steve_northover>
Component:	JS Tools	Assignee:	Eric Moffatt <emoffatt>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	Carolyn_MacLeod, curtis.windatt.public, Michael_Rennie
Version:	unspecified
Target Milestone:	9.0
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Steve Northover

2015-06-01 16:12:23 EDT

1) Use this text

function zzz() {
    var hello = 12;
    hello++;
}

2) put the curso on "hello"
3) Tools->Rename Element
4) BUG: keystrokes go nowhere and variable is not renamed

Comment 1 Carolyn MacLeod

2015-06-02 10:36:31 EDT

Confirmed that Tools->Rename Element does not work from menu in either FF or Chrome. It does work using the keyboard in both browsers.

Comment 2 Carolyn MacLeod

2015-06-02 11:46:55 EDT

In case it's helpful, note that File -> Rename seems to break regularly... see bug 379259 and bug 429916.

Comment 3 Carolyn MacLeod

2015-06-02 11:51:58 EDT

Please ignore comment 2 - that is for renaming files (not "elements").

Comment 4 Eric Moffatt

2015-06-10 09:58:58 EDT

We've changed the code so that contributed editor commands always set the focus onto the editor (meaning that the rename command itself doesn't have to change). For explicit editor commands (as created in editorCommands) have also been modified to explicitly set the focus if necessary (i.e. for the Blame command).

commit: 32d82bb32214844170b7c08d2eb0b26854df5750

Comment 5 Steve Northover

2015-06-10 10:02:54 EDT

Woot!  Please check the other menu items in both the popup and menu bar to ensure that they also work ... but you did this already ...