Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 468804

Summary:	Consistently use abbreviations (Fx, Mvc, Ui, etc.) in class, interface, and method names.
Product:	[Tools] GEF	Reporter:	Matthias Wienand <matthias.wienand>
Component:	Misc	Assignee:	gef-inbox <gef-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	nyssen
Version:	unspecified
Target Milestone:	4.0.0 (Neon) M6
Hardware:	All
OS:	All
Whiteboard:
Bug Depends on:	481748
Bug Blocks:

Description Matthias Wienand

2015-05-29 10:39:49 EDT

Throughout the GEF4 code base, it should be ensured that:
1) Abbreviations (like Fx, Mvc, Ui, etc.) are consistently written:
   - "FXConnection" vs "FxBundle"
   - "FXTransformProvider" vs "ZestFxCursorProvider"
2) Pre- and post-fixes are consistently added to names:
   - "FXHoverFeedbackPart" vs "HiddenNeighborsPart"
   - "FXView" vs "ZestFxUiView"

Comment 1 Alexander Nyßen

2015-06-04 00:38:09 EDT

This especially holds for Zest.FX, where classes with no prefix are mixed with classes using 'ZestFx' even within a single package.

Comment 2 Alexander Nyßen

2015-11-09 12:09:30 EST

Where the context is clear, we should remove prefixes like 'FX' or 'ZestFX' to make the names more consistent. 

In the FX bundle (org.eclipse.gef4.fx) for instance, all classes provide extensions/additions for/to JavaFX. As these classes will always be used in an JavaFX context, the 'FX' prefix does not bring much benefit.

In contrast, the FX.SWT and FX.JFace bundles should preserve the FX prefix in their class names, as they provide SWT and JFace extensions, which will be used in an SWT/JFace context. Here 'FX' indicates that a JavaFX-integration is implemented.

Comment 3 Alexander Nyßen

2016-02-03 07:20:00 EST

I pushed the following changes to origin/master to resolve the last issues we have found (so far):

- Renamed SwtToFxEventConverter into SWT2FXEventConverter.
- Renamed Geometry2JavaFX into Geometry2FX.
- Renamed JavaFX2Geometry into FX2Geometry.
- Renamed o.e.g4.zest.fx.SelectionHandlePartFactory into    ZestFxSelectionHandlePartFactory.
- Renamed o.e.g4.zest.fx.HoverHandlePartFactory into ZestFxHoverHandlePartFactory.
- Renamed o.e.g4.zest.fx.ContentPartFactory into ZestFxContentPartFactory.
- Renamed FxApplicationThreadRule to FXApplicationThreadRule.
- Renamed FxNonApplicationThreadRule to FXNonApplicationThreadRule.
- Renamed DotToZestGraphConverter to Dot2ZestGraphConverter.
- Renamed SwtToFXGestureConversionDemo to SWT2FXGestureConversionDemo.

Resolving as fixed in 4.0.0 M6.