Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 468498

Summary: [server] New methods need to be implemented by ExcludedExtensionGzipFilter
Product: [ECD] Orion Reporter: Anthony Hunter <ahunter.eclipse>
Component: ServerAssignee: Anthony Hunter <ahunter.eclipse>
Status: CLOSED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: rushingrussian
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard:
Bug Depends on:    
Bug Blocks: 444496    

Description Anthony Hunter CLA 2015-05-27 12:01:01 EDT
Moving to Jetty 9 as part of Bug 444496 also requires moving to javax servlet 3.1. There are two new methods on ServletOutputStream that need to be implemented within the ServletOutputStreamWrapper in ExcludedExtensionGzipFilter:

public boolean isReady()
public void setWriteListener(WriteListener writeListener)

Need to investigate what the methods need to return.
Comment 1 Dmitry Shindyalov CLA 2015-11-03 10:20:57 EST
I am looking into this.
Comment 2 Dmitry Shindyalov CLA 2015-11-08 18:02:22 EST
public abstract boolean isReady()

Checks if a non-blocking write will succeed. If this returns false, it will cause a callback to WriteListener.onWritePossible() when the buffer has emptied. If this method returns false no further data must be written until the contain calls WriteListener.onWritePossible().

Returns:
true if data can be written, else false

public abstract void setWriteListener(WriteListener listener)

Sets the WriteListener for this ServletOutputStream and thereby switches to non-blocking IO. It is only valid to switch to non-blocking IO within async processing or HTTP upgrade processing.

Parameters:
listener - The non-blocking IO write listener

Throws:
java.lang.IllegalStateException - If this method is called if neither async nor HTTP upgrade is in progress or if the WriteListener has already been set
java.lang.NullPointerException - If listener is null
Comment 3 Michael Rennie CLA 2017-01-10 15:44:31 EST
Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see:

https://dev.eclipse.org/mhonarc/lists/orion-dev/msg04002.html