Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 468485

Summary:	[server][git] Issue with git object during creation of workspace
Product:	[ECD] Orion	Reporter:	Yossi Balan <yossi.balan>
Component:	Git	Assignee:	Yossi Balan <yossi.balan>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	Silenio_Quarti
Version:	8.0
Target Milestone:	11.0
Hardware:	PC
OS:	Windows 7
URL:	https://git.eclipse.org/r/#/c/51423/
See Also:	https://git.eclipse.org/r/51423 https://git.eclipse.org/r/52032 https://git.eclipse.org/r/52033 https://git.eclipse.org/r/57907 https://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=b56b4004cdd9648f6ed3e29b8fc8491a45fdeedc
Whiteboard:

Description Yossi Balan

2015-05-27 10:29:46 EDT

Hi

in class GitFileDecorator method addAtributesFor the addGitLinks is call only for the first level of the structure, meaning if you have workspace of file and folder the addGitLinks will be called only for the first level and not for the children.

Regards,
Yossi

Comment 1 Yossi Balan

2015-05-27 15:00:15 EDT

I want to contribute and to fix this bug

Comment 2 Eclipse Genie

2015-07-06 12:14:55 EDT

New Gerrit change created: https://git.eclipse.org/r/51423

Comment 3 Eclipse Genie

2015-07-16 02:06:32 EDT

New Gerrit change created: https://git.eclipse.org/r/52032

Comment 4 Eclipse Genie

2015-07-16 02:09:14 EDT

New Gerrit change created: https://git.eclipse.org/r/52033

Comment 5 Silenio Quarti

2015-07-16 10:44:48 EDT

Is there a case where you require multiple levels of children? I believe the Orion UI only uses one level.

Comment 6 Yossi Balan

2015-07-18 15:49:27 EDT

In my case I need to get the this object for all the levels. we have the call to get the data with /?depth=1000

Comment 7 Yossi Balan

2015-07-19 02:04:18 EDT

for example this call https://..../orion/s2s/file/x580b10a7$<user name>-OrionContent/<folder name>/?depth=1000

Comment 8 Silenio Quarti

2015-07-20 10:16:45 EDT

Ok, makes sense.

Note that we have been talking about removing the decorators and provide a different API to access git info, etc.  Decorating the whole tree is kind of inefficient and it adds hard dependency between the file system and git. Making it hard to implement other file systems.

But in the mean time, while the new API is not in place, fixing this bug makes sense.

I added some comments to the patch set in comment#2. Is that the latest changes? You have submitted 3 different patches.

Comment 9 Yossi Balan

2015-07-20 10:42:10 EDT

I fixed your comment and add it to the last patch

Comment 10 Eclipse Genie

2015-10-10 14:40:13 EDT

New Gerrit change created: https://git.eclipse.org/r/57907

Comment 11 Eclipse Genie

2015-11-25 16:18:26 EST

Gerrit change https://git.eclipse.org/r/57907 was merged to [master].
Commit: http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=b56b4004cdd9648f6ed3e29b8fc8491a45fdeedc

Comment 12 John Arthorne

2015-11-25 16:20:04 EST

Sorry for forgetting about this one for so long, Yossi. I have reviewed and merged. Thanks for your contribution!