Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 46839

Summary: [RCP] Auto-save on build leaves progress bar showing in status line
Product: [Eclipse Project] Platform Reporter: Nick Edgar <n.a.edgar>
Component: UIAssignee: Nick Edgar <n.a.edgar>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 3.0   
Target Milestone: 3.0 M6   
Hardware: PC   
OS: Windows 2000   
Whiteboard:

Description Nick Edgar CLA 2003-11-18 10:32:21 EST
build N20031117

- turn on the Workbench pref to save changes on build 
- open a file
- make some changes, but don't save
- Ctrl+B

The progress bar in the status line is left showing (at 100%).

Ctrl+S does not have the same problem.

This is a regression from M4.
Comment 1 Nick Edgar CLA 2003-11-18 11:25:09 EST
The progress monitor's done() method is not being called.
We used to get a free done() from the call to workspace.run in 
EditorManager.saveAll, however this was removed due to the RCP changes (see bug 
46844).

Comment 2 Nick Edgar CLA 2003-11-18 11:34:40 EST
Added explicit call to done() in saveAll.
Also reinstated used of EventLoopProgressMonitor.  See bug 46844.