Bugzilla – Full Text Bug Listing
| Summary: | [GTK3] Background not painted correctly when using SWT.EraseItem | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Bernd Hufmann <bernd.hufmann> | ||||
| Component: | SWT | Assignee: | Sravan Kumar Lakkimsetti <sravankumarl> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | critical | ||||||
| Priority: | P3 | CC: | adietish, arunkumar.thondapu, bernd.hufmann, lshanmug, malaperle, niraj.modi, peter, snjezana.peco, sravankumarl | ||||
| Version: | 4.5 | Flags: | arunkumar.thondapu:
review+
|
||||
| Target Milestone: | 4.5.1 | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| See Also: |
https://git.eclipse.org/r/48708 https://git.eclipse.org/r/53548 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=292196c4f29d5ffc8c6ae5f731cf6d40723a6ba1 |
||||||
| Whiteboard: | |||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 441566, 474628 | ||||||
| Attachments: |
|
||||||
|
Description
Bernd Hufmann
Execution environment: I'm running Ubuntu 14.04 with GTK3 version 3.10.8. Created attachment 253737 [details]
Example
Example application to demonstrate the bug.
1) Import the Eclipse plug-in to workspace
2) run TableShellExample as Java Application
Run it as GTK2 and then GTK3.
In the GTK2 the whole row has green background. GTK3 only the very left of each column has the green background.
Bernd, could you try with M7? It could be related to the fix for bug 438505. (In reply to Marc-Andre Laperle from comment #3) > Bernd, could you try with M7? It could be related to the fix for bug 438505. Thanks Marc-Andre. M7 has the same issue. Increased importance. Trace Compass uses the SWT.EraseItem listener for special highlighting in a table and it's an important feature for the application. (In reply to Bernd Hufmann from comment #4) > (In reply to Marc-Andre Laperle from comment #3) > > Bernd, could you try with M7? It could be related to the fix for bug 438505. > > Thanks Marc-Andre. > > M7 has the same issue. The issue can be reproduced in GTK >= 3.10 and any Eclipse distribution. New Gerrit change created: https://git.eclipse.org/r/48708 (In reply to Snjezana Peco from comment #6) > (In reply to Bernd Hufmann from comment #4) > > (In reply to Marc-Andre Laperle from comment #3) > > > Bernd, could you try with M7? It could be related to the fix for bug 438505. > > > > Thanks Marc-Andre. > > > > M7 has the same issue. > > The issue can be reproduced in GTK >= 3.10 and any Eclipse distribution. please have a look at the patch at https://git.eclipse.org/r/48708. This change helps in fixing the problem but I think we need to think for a better fix It seems below workaround-fix for bug 459117 in 4.5M7 has introduced this problem: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=a448e5fba612fd4d50d640de1bf1837494976dba If we don't reach a proper fix for this bug, should we consider reverting above patch ? (In reply to Niraj Modi from comment #9) > It seems below workaround-fix for bug 459117 in 4.5M7 has introduced this > problem: > http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/ > ?id=a448e5fba612fd4d50d640de1bf1837494976dba > > If we don't reach a proper fix for this bug, should we consider reverting > above patch ? I think reverting will introduce a bigger problem here. The leaking text won't look nice. In my opinion reverting the code fix for leaking text is bigger evil than this problem This is very late for 4.5 release. can we triage this for 4.5.1? (In reply to Sravan Kumar Lakkimsetti from comment #10) > > I think reverting will introduce a bigger problem here. The leaking text > won't look nice. > > In my opinion reverting the code fix for leaking text is bigger evil than > this problem Agree. https://git.eclipse.org/r/48708 fixes the issue. Since the issue can't be reproduced on GTK>=3.14, the patch (as well as the workaround for bug 459117) isn't necessary for those GTK versions. Thanks for looking into this. I would appreciate if it could be part of 4.5. A central feature of Trace Compass would not be working well with GTK3 and we would need to suggest to the users to switch to GTK2. I'd like to test the patch. But I'm not able to run the code using the patch because I haven't figured out how to run it from source code. Any instructions for that? Thanks Bernd (In reply to Bernd Hufmann from comment #13) > Thanks for looking into this. > > I would appreciate if it could be part of 4.5. > > A central feature of Trace Compass would not be working well with GTK3 and > we would need to suggest to the users to switch to GTK2. > > I'd like to test the patch. But I'm not able to run the code using the patch > because I haven't figured out how to run it from source code. > > Any instructions for that? > > Thanks > Bernd See http://www.eclipse.org/swt/git.php (In reply to Snjezana Peco from comment #14) > See http://www.eclipse.org/swt/git.php Thanks! I tried the fix for the table and it works. It looks good for Trace Compass. I don't have a test case for the tree though. Are you going to merge that for 4.5? (In reply to Bernd Hufmann from comment #15) > (In reply to Snjezana Peco from comment #14) > > See http://www.eclipse.org/swt/git.php > Thanks! > > I tried the fix for the table and it works. It looks good for Trace Compass. > > I don't have a test case for the tree though. > > Are you going to merge that for 4.5? This patch fixes only the usecase mentioned in this bug. It doesn't completely fix the problem. We are inclined to put this in SR1 timeframe. Also we feel this is very risky to do this Since this bug fix is quite risky I am suggesting it to triage to 4.5.1 (In reply to Sravan Kumar Lakkimsetti from comment #17) > Since this bug fix is quite risky I am suggesting it to triage to 4.5.1 From my point of view it would great if a fix would be available for 4.5. Having said that, you know the source code better than me and you have to decide what is the right thing to do. We definitely don't want to break other things with this late patch. Thanks Bernd Fixed in master, will leave the bug open for backporting to 4.5.1. I have tested it using Ubuntu 14.04(gtk 3.10.8) and Kubuntu 15.05(gtk 3.14.13) found no issues. (In reply to Sravan Kumar Lakkimsetti from comment #20) > I have tested it using Ubuntu 14.04(gtk 3.10.8) and Kubuntu 15.05(gtk > 3.14.13) found no issues. +1 for backporting to 4.5.1. back ported to 4.5.1 through https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?h=R4_5_maintenance&id=11ab3fb41bc0630b5fd28e3919ec55eaccb72e67 Bernd, can you test the committed fix (in master) to see if the issue in Trace Compass is fixed or can you remind me what to test? |