Bugzilla – Full Text Bug Listing
| Summary: | Enable GTK3 mode for eclipse on ppc64le platform | ||
|---|---|---|---|
| Product: | [Eclipse Project] Equinox | Reporter: | Sravan Kumar Lakkimsetti <sravankumarl> |
| Component: | Launcher | Assignee: | Sravan Kumar Lakkimsetti <sravankumarl> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | akurtakov, arunkumar.thondapu, daniel_megert, lshanmug, niraj.modi, robertoguimaraes8, sravankumarl, tjwatson |
| Version: | 4.5.0 Mars | Flags: | daniel_megert:
pmc_approved+
arunkumar.thondapu: review+ lshanmug: review+ niraj.modi: review+ |
| Target Milestone: | Mars RC3 | ||
| Hardware: | Power PC | ||
| OS: | Linux | ||
| See Also: |
https://git.eclipse.org/r/48448 https://git.eclipse.org/c/equinox/rt.equinox.framework.git/commit/?id=db53ed0dece0186f5ea1adad05151206f8f259ce https://git.eclipse.org/r/48749 https://git.eclipse.org/c/equinox/rt.equinox.framework.git/commit/?id=5a2836db6e265d81efbc69ea784f540f8ba30a4d https://git.eclipse.org/r/49185 https://bugs.eclipse.org/bugs/show_bug.cgi?id=469113 |
||
| Whiteboard: | |||
| Bug Depends on: | 467664 | ||
| Bug Blocks: | |||
|
Description
Sravan Kumar Lakkimsetti
New Gerrit change created: https://git.eclipse.org/r/48448 I do have a fundamental question on doing this for 4.5. We have never build GTK3 based SWT on linux ppc64le platform. Now we are able to setup the build machine and build GTK3 based SWT libraries on ppc64le platform. But the question I have is whether to do it or not as this may be treated as new platform getting added in RC3 time frame. The gerrit patch https://git.eclipse.org/r/48448 contains the required changes. Please provide your review comments I'll leave this up to Dani to decide since it does not really effect Equinox itself. But it seems risky to me to right at the end to jump to GTK3, but perhaps I have misunderstood. (In reply to Thomas Watson from comment #3) > I'll leave this up to Dani to decide since it does not really effect Equinox > itself. But it seems risky to me to right at the end to jump to GTK3, but > perhaps I have misunderstood. On the other side looking from bug 441421 POV - linux ppc64le has been broken for the whole Mars development time. (In reply to Alexander Kurtakov from comment #4) > (In reply to Thomas Watson from comment #3) > > I'll leave this up to Dani to decide since it does not really effect Equinox > > itself. But it seems risky to me to right at the end to jump to GTK3, but > > perhaps I have misunderstood. > > On the other side looking from bug 441421 POV - linux ppc64le has been > broken for the whole Mars development time. What has this to do with GTK+ 2 vs. GTK+ 3? The real question is: do we think that PPC LE is more stable on GTK+ 2 or on GTK+ 3. WDYT Sravan , Alex and Arun? I ment that ppc64le was added with 4.4 and from the referenced bug the build from eclipse.org was broken so was during the whole Mars release cycle - which means that there were no users up until now (more or less). With that in mind - why put new(as there are no current) users on GTK 2 to make them see the diffs with GTK3 on the next release. FWIW, we provide ppc64le builds in Fedora and 4.4.x default to GTK2 but 4.5.x default to GTK3. (In reply to Alexander Kurtakov from comment #6) > I ment that ppc64le was added with 4.4 and from the referenced bug the build > from eclipse.org was broken so was during the whole Mars release cycle - > which means that there were no users up until now (more or less). With that > in mind - why put new(as there are no current) users on GTK 2 to make them > see the diffs with GTK3 on the next release. > FWIW, we provide ppc64le builds in Fedora and 4.4.x default to GTK2 but > 4.5.x default to GTK3. Alex, sorry to be a PITA, but fist, PPC LE support is new for 4.5 and your comment does not answer my question at all. Please respond to this: > The real question is: do we think that PPC LE is more stable on GTK+ 2 or on > GTK+ 3. WDYT Sravan , Alex and Arun? (In reply to Dani Megert from comment #7) > (In reply to Alexander Kurtakov from comment #6) > > I ment that ppc64le was added with 4.4 and from the referenced bug the build > > from eclipse.org was broken so was during the whole Mars release cycle - > > which means that there were no users up until now (more or less). With that > > in mind - why put new(as there are no current) users on GTK 2 to make them > > see the diffs with GTK3 on the next release. > > FWIW, we provide ppc64le builds in Fedora and 4.4.x default to GTK2 but > > 4.5.x default to GTK3. > > Alex, sorry to be a PITA, but fist, PPC LE support is new for 4.5 and your > comment does not answer my question at all. > > Please respond to this: > > > The real question is: do we think that PPC LE is more stable on GTK+ 2 or on > > GTK+ 3. WDYT Sravan , Alex and Arun? Hi Dani, The minimum versions for GTK2 and GTK3 we can support for ppc64le are 2.24 and 3.10 respectively(based on the versions available on the build system). GTK3.10 and above is enabled in 4.5.x release only. We were falling back to GTK2 in 4.4.x. In my opinion GTK2 would be better. But as Alex said it would be better to put users on GTK3 as any problem encountered by users on GTK3 will be same as any other GTK3 platform(like linux x86/x86_64 platfoms). I am inclined to go with enabling GTK3 -Sravan (In reply to Dani Megert from comment #7) > (In reply to Alexander Kurtakov from comment #6) > > I ment that ppc64le was added with 4.4 and from the referenced bug the build > > from eclipse.org was broken so was during the whole Mars release cycle - > > which means that there were no users up until now (more or less). With that > > in mind - why put new(as there are no current) users on GTK 2 to make them > > see the diffs with GTK3 on the next release. > > FWIW, we provide ppc64le builds in Fedora and 4.4.x default to GTK2 but > > 4.5.x default to GTK3. > > Alex, sorry to be a PITA, but fist, PPC LE support is new for 4.5 and your > comment does not answer my question at all. Hi Dani, ppc64le support was available in 4.4.1 as early access and from 4.4.2 as supported platform with only gtk2 support. But, for 4.4.x, gtk2 was the default on Unix platforms, so gtk3 support not being available for ppc64le was not a problem. From 4.5, gtk3 will be the default. So, I think it makes sense to have gtk3 as the default on ppc64le too. We couldn't do this earlier in the Mars cycle, since we didn't have the machine + gtk3 setup to so the builds. Now, we have built the required swt-gtk3 library and it is already in the SWT binaries repository. We only need to make the launcher change for the gtk3 library to be used (i.e, revert changes made in Bug 441421) and then perform a sanity test for eclipse on gtk3 to confirm that it is working fine. > > Please respond to this: > > > The real question is: do we think that PPC LE is more stable on GTK+ 2 or on > > GTK+ 3. WDYT Sravan , Alex and Arun? IMHO, ppcle on gtk2 or gtk3 will be the same as any other SWT supported linux platform on gtk2 or gtk3. We can confirm that only when we test with an eclipse build that can launch with gtk3 on ppc64le. Also, as Sravan and Alex mentioned, its better to put users on gtk3 so that any issues can be caught and addressed. Users do have the option of launching with gtk2 if required using the SWT_GTK3=0 switch. (In reply to Lakshmi Shanmugam from comment #9) > Hi Dani, > ppc64le support was available in 4.4.1 as early access and from 4.4.2 as > supported platform with only gtk2 support. But, for 4.4.x, gtk2 was the > default on Unix platforms, so gtk3 support not being available for ppc64le > was not a problem. Yep, I meant new in a major release. Having heard all your arguments I'm fine going with GTK+ 3, but we must ensure to have a test pass with big coverage for ppcle, and after 4.5 shipped keep an eye on reported bugs and fix them in 4.5.1. Gerrit change https://git.eclipse.org/r/48448 was merged to [master]. Commit: http://git.eclipse.org/c/equinox/rt.equinox.framework.git/commit/?id=db53ed0dece0186f5ea1adad05151206f8f259ce (In reply to Eclipse Genie from comment #11) > Gerrit change https://git.eclipse.org/r/48448 was merged to [master]. > Commit: > http://git.eclipse.org/c/equinox/rt.equinox.framework.git/commit/ > ?id=db53ed0dece0186f5ea1adad05151206f8f259ce Sravan, as per our discussion (I've updated in gerrit as well), I've pushed the patch and we should test the builds with different versions of GTK3 on ppc64le (preferably on RHEL 7.x to test with GTK < 3.10.9 and other distros with GTK > 3.10.9). Just to be clear, this bug needs a third review+ and a notification on platform-releng-dev before the launcher binaries are rebuilt and committed to git. +1, patch looks good to me. +1 Code changes looks good and is well isolated for ppc64le only. New Gerrit change created: https://git.eclipse.org/r/48749 Gerrit change https://git.eclipse.org/r/48749 was merged to [master]. Commit: http://git.eclipse.org/c/equinox/rt.equinox.framework.git/commit/?id=5a2836db6e265d81efbc69ea784f540f8ba30a4d Launcher has been rebuilt and commited though the following https://git.eclipse.org/c/equinox/rt.equinox.binaries.git/commit/?id=6b6536cf391e64ebb570d0ac1bc2e5e59808a3af and https://git.eclipse.org/c/equinox/rt.equinox.framework.git/commit/?id=456cd343ff6bf630e9f1571bc51d5ab26b20eeaf New Gerrit change created: https://git.eclipse.org/r/49185 Marking as fixed. Launcher was enabled to run in gtk3 mode with some version checks in 4.5RC3. Bug 469113 is to remove the above gtk3 specific version checks for ppc64le. Verified with RC3 on SLES 12 (GTK 3.10.9). |