Bugzilla – Full Text Bug Listing
| Summary: | Replace bindings to IViewer adaptable scope within MvcFxModule to bind to FXViewer adaptable scope. | ||
|---|---|---|---|
| Product: | [Tools] GEF | Reporter: | Alexander Nyßen <nyssen> |
| Component: | GEF MVC | Assignee: | gef-inbox <gef-inbox> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | ||
| Version: | 0.1.0 | ||
| Target Milestone: | 3.10.0 (Mars) RC1 | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
Changed that Node-parameterized bindings of ContentPartPool and FocusModel are now bound to FXViewer adaptable scope. Verified that this does not affect the scoping of both. Pushed changes to origin/master. Resolving as fixed in 3.10.0RC1. |
There are two bindings within MvcFxModule, which bind Node-parameterized types to the adaptable scope of IViewer: protected void bindContentBehaviorPartPool() { binder().bind(new TypeLiteral<ContentPartPool<Node>>(){}).in(AdaptableScopes.typed(IViewer.class)); } protected void bindFocusModel() { binder().bind(new TypeLiteral<FocusModel<Node>>(){}).in(AdaptableScopes.typed(IViewer.class)); } This does not really harm anyone at the moment, but it would be cleaner to bind them to FXViewer scope instead of IViewer scope, as both models are parameterized with Nodes.