Bugzilla – Full Text Bug Listing
| Summary: | Branding icons eclipse16.png is missing | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] PDE | Reporter: | Vikas Chandra <Vikas.Chandra> | ||||||
| Component: | UI | Assignee: | Lars Vogel <Lars.Vogel> | ||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | Lars.Vogel, markus.kell.r, Vikas.Chandra | ||||||
| Version: | 4.5 | Flags: | Vikas.Chandra:
review+
|
||||||
| Target Milestone: | 4.5 RC1 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows 7 | ||||||||
| See Also: |
https://git.eclipse.org/r/47632 https://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=e0466aff57d13ae5c10c4fba6330919863f85df2 |
||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
Created attachment 253359 [details]
this icon should be restored at /org.eclipse.pde.ui/icons/obj16/
Lars, can you please look at this and any other icons that may be missing in the same way as this one. Fixed with http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=7dd6a68c220de1314dff09f60d8fa13ac48146be . *** This bug has been marked as a duplicate of bug 466840 *** I cant see branding icons after pulling the latest code. That's probably because org.eclipse.pde.ui/icons/obj16/eclipse16.png Lars, can you please re-check? Not a dup & not fixed. This is the other eclipse16.png that was found missing in bug 433714 comment 73. It is referenced in code in PDEPluginImages#DESC_PRODUCT_BRANDING. (In reply to Vikas Chandra from comment #5) > I cant see branding icons after pulling the latest code. > > That's probably because org.eclipse.pde.ui/icons/obj16/eclipse16.png Missed that, as this is not part of the plugin.xml. Sorry, again. Fixing that soon. New Gerrit change created: https://git.eclipse.org/r/47632 With this change, as icons in the product editor are present AFAICS. Please +1 so that this can be included in the build. Gerrit change https://git.eclipse.org/r/47632 was merged to [master]. Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=e0466aff57d13ae5c10c4fba6330919863f85df2 Thanks Vikas for the review flag. I will verify this in tomorrow's build. I will also try to find anything else in and around this area during verification. Verified in 4.5.0.I20150511-2130 |
Created attachment 253358 [details] See the icon of branding On eclipse-SDK-I20150507-2000-win32-x86_64 See image attached