Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 466784

Summary: [Graphics] Create png icons for org.eclipse.e4.tools.css.spy
Product: [Eclipse Project] Platform Reporter: Lars Vogel <Lars.Vogel>
Component: UIAssignee: Matthias Becker <ma.becker>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: Lars.Vogel, ma.becker, psuzzi, tmccrary
Version: 4.5   
Target Milestone: 4.7 M3   
Hardware: PC   
OS: Linux   
See Also: https://git.eclipse.org/r/81005
https://git.eclipse.org/r/81006
https://git.eclipse.org/c/platform/eclipse.platform.images.git/commit/?id=d5269104baa20eb947ef98b3a247b5688b2ef63a
https://git.eclipse.org/c/e4/org.eclipse.e4.tools.git/commit/?id=28ac389271f4eac7bb5e155fa191f22b9b946982
Whiteboard:
Attachments:
Description Flags
Comparison of old ( left ) and new ( right ) of bundle.spy
none
Comparison of old ( left ) and new ( right ) of context.spy
none
Comparison of old ( left ) and new ( right ) of css.spy
none
Comparison of old ( left ) and new ( right ) of event.spy none

Description Lars Vogel CLA 2015-05-07 17:24:38 EDT 
In ssh://user@git.eclipse.org:29418/e4/org.eclipse.e4.tools we have the CSS spy with two Gif which look ugly in the dark theme. 

Tony, could you add svg and png version for these two icons?

cssspy.gif looks IMHO good as template but css_scratchpad.gif is ugly, would be nice if you create a new icon.
Comment 1 Lars Vogel CLA 2016-09-13 04:16:30 EDT 
Matthias, could you handle that for M3?
Comment 2 Matthias Becker CLA 2016-09-13 06:41:32 EDT 
one question regarding css_scratchpad.gif:
Do you find it ugly because it's a gif or is it the design you don't like?
Comment 3 Matthias Becker CLA 2016-09-13 07:18:26 EDT 
The org.eclipse.e4.tools repo also contains some other GIFs e.g.

in 
org.eclipse.e4.tools.context.spy
org.eclipse.e4.toolsevent.spy
org.eclipse.e4.toolsbundle.spy
org.eclipse.e4.toolsorion.css.editor

what should happen with these?
Comment 4 Lars Vogel CLA 2016-09-13 07:50:40 EDT 
(In reply to Matthias Becker from comment #2)
> one question regarding css_scratchpad.gif:
> Do you find it ugly because it's a gif 

+1

or is it the design you don't like?

I think the design looks OK, but if you have something else in mind, I'm most likely also OK with a new icon, depending on your suggestion.

org.eclipse.e4.tools.context.spy
org.eclipse.e4.toolsevent.spy
org.eclipse.e4.toolsbundle.spy

Would be great, if you can fix these also.

org.eclipse.e4.toolsorion.css.editor

This is unmaintained, no need to provide icons for this one.
Comment 5 Eclipse Genie CLA 2016-09-13 11:21:28 EDT 
New Gerrit change created: https://git.eclipse.org/r/81005
Comment 6 Eclipse Genie CLA 2016-09-13 11:21:50 EDT 
New Gerrit change created: https://git.eclipse.org/r/81006
Comment 7 Matthias Becker CLA 2016-09-13 11:23:22 EDT 
Created attachment 264126 [details]
Comparison of old ( left ) and new ( right ) of bundle.spy
Comment 8 Matthias Becker CLA 2016-09-13 11:24:01 EDT 
Created attachment 264127 [details]
Comparison of old ( left ) and new ( right ) of context.spy
Comment 9 Matthias Becker CLA 2016-09-13 11:24:59 EDT 
Created attachment 264128 [details]
Comparison of old ( left ) and new ( right ) of css.spy
Comment 10 Matthias Becker CLA 2016-09-13 11:25:27 EDT 
Created attachment 264129 [details]
Comparison of old ( left ) and new ( right ) of event.spy
Comment 11 Matthias Becker CLA 2016-09-13 11:27:10 EDT 
(In reply to Lars Vogel from comment #1)
> Matthias, could you handle that for M3?

Done.
Comment 12 Lars Vogel CLA 2016-09-13 11:40:50 EDT 
(In reply to Matthias Becker from comment #11)
> (In reply to Lars Vogel from comment #1)
> > Matthias, could you handle that for M3?
> 
> Done.

Thanks. Looks good to me, will merge after our M2 release.
Comment 15 Lars Vogel CLA 2016-09-16 10:07:40 EDT 
Thanks Matthias