Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 466605

Summary: Corner cases of bug 441090 - Border nodes are moved, they should not
Product: [Modeling] Sirius Reporter: Laurent Redor <laurent.redor>
Component: DiagramAssignee: Laurent Redor <laurent.redor>
Status: CLOSED FIXED QA Contact: Belqassim Djafer <belqassim.djafer>
Severity: normal    
Priority: P3 CC: maxime.porhel, pierre-charles.david
Version: 2.0.0Keywords: triaged
Target Milestone: 3.0.0   
Hardware: PC   
OS: Linux   
See Also: https://bugs.eclipse.org/bugs/show_bug.cgi?id=441090
https://git.eclipse.org/r/47463
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=1b095ac99a1641aa308fc77ea0e23614d432b803
Whiteboard:
Attachments:
Description Flags
movedBorderNodes.zip for steps to reproduce
none
movedBorderNodes.zip for steps to reproduce none

Description Laurent Redor CLA 2015-05-06 11:50:03 EDT
Created attachment 253236 [details]
movedBorderNodes.zip for steps to reproduce

Steps to reproduce:

* Import project movedBorderNodes (from movedBorderNodes.zip). Data is inspired from org.eclipse.sirius.tests.swtbot.PortsOnNodePositionStabilityTest.
* Open diagWithBorderNodeOnNode
* Resize gray p31 container from the top side in the bottom direction
* Bordre nodes A and B move. They should not.
Comment 1 Eclipse Genie CLA 2015-05-07 12:34:18 EDT
New Gerrit change created: https://git.eclipse.org/r/47463
Comment 2 Eclipse Genie CLA 2015-05-11 11:42:49 EDT
WARNING: this patchset contains 2909 new lines of code and may require a Contribution Questionnaire (CQ) if the author is not a committer on the project. Please see:https://wiki.eclipse.org/Project_Management_Infrastructure/Creating_A_Contribution_Questionnaire
Comment 3 Laurent Redor CLA 2015-05-11 11:58:46 EDT
Another problem is when border node "came out" of the container, steps to reproduce:

* Import project movedBorderNodes (from movedBorderNodes.zip). Data is inspired from org.eclipse.sirius.tests.swtbot.PortsOnNodePositionStabilityTest.
* Open diagWithBorderNodeOnNode
* Resize gray p32 container from the top side in the bottom direction (just under D)
* KO: Bordre node C is on the top side and border node D is at the bottom of the right side.
Border node C should be on the top of the right side, and border node D should be just below.
Comment 4 Laurent Redor CLA 2015-05-11 11:59:31 EDT
Created attachment 253387 [details]
movedBorderNodes.zip for steps to reproduce
Comment 6 Laurent Redor CLA 2015-05-12 05:14:35 EDT
Fixed with above commit.
Comment 7 Belqassim Djafer CLA 2015-05-21 10:55:58 EDT
Verified with Sirius 3.0.0 RC1
Comment 8 Pierre-Charles David CLA 2015-06-24 11:15:52 EDT
Available in Sirius 3.0.0. See https://wiki.eclipse.org/Sirius/3.0.0.