Bugzilla – Full Text Bug Listing
| Summary: | [GTK3] [GTK3.14] Path text not drawn in column of commit dialog window | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Marc-André Laperle <malaperle> | ||||||||
| Component: | SWT | Assignee: | Snjezana Peco <snjezana.peco> | ||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||
| Severity: | major | ||||||||||
| Priority: | P3 | CC: | adietish, akurtakov, arunkumar.thondapu, daniel_megert, exdata2, gapage, janosbinder, loskutov, luis.de.sousa, markus.kell.r, matt_miraglia, neillfontes, oded, peter, renan.puppo, renda.krell, sbernard, scarabol, snjezana.peco, wywrzal | ||||||||
| Version: | 4.5 | Flags: | akurtakov:
review+
arunkumar.thondapu: review+ |
||||||||
| Target Milestone: | 4.5.1 | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Linux | ||||||||||
| See Also: |
https://git.eclipse.org/r/48343 https://bugs.eclipse.org/bugs/show_bug.cgi?id=461251 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=e32fa8a623210ebcb62b7d869996492857cb244c https://git.eclipse.org/r/53470 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=a41f152c868984b41b73945f374966ad621c3e13 https://bugs.eclipse.org/bugs/show_bug.cgi?id=480032 |
||||||||||
| Whiteboard: | |||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 441566, 467933, 474628 | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 253194 [details]
Using GTK2
It works correctly on Ubuntu 14.04 with GTK 3.10.8. New Gerrit change created: https://git.eclipse.org/r/48343 This issue has been introduced by GTK 3.14.0. It can be reproduced by running the following snippet: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/tree/examples/org.eclipse.jface.snippets/Eclipse%20JFace%20Snippets/org/eclipse/jface/snippets/viewers/Snippet050DelegatingStyledCellLabelProvider.java You should run the snippet with GTK >= 3.14.0 and uncheck only one from the two "Owner draw ..." checkboxes. The patch https://git.eclipse.org/r/48343 fixes the issue. I have tested most of the bugs related to bug 446075 and bug 459117. It also fixes bug 461251. In reply to Alexander Kurtakov > SO the problem is that GTK_IS_CELL_RENDERER_PIXBUF if given pixbuf returns > false and the patch assumes that every renderer is pixbuf_renderer. This > doesn't sound correct to me and my gut feelings are telling me this will cause > other problems. Is there some change in the way renderers are supposed to be > registered with 3.14 ? Entry point for what/how is registered in SWT is > Display.createDisplay(DeviceData) . The approach taken in this patch looks too > risky as it will make toggle/text renderers enter this codepath. There aren't any changes related to registering renderers in 3.14. However, GTK < 3.14 sends two rendererRender signals for every tree cell. SWT creates measureItem/eraseItem and paintItem events in rendererRender based on those two signals. GTK >= 3.14 also sends two signals for cell 0, but only one (paint) for other cells. The patch creates the additional measureItem/eraseItem event for other cells if columnIndex != 0 and version >= 3.14 regardless of GTK_IS_CELL_RENDERER_PIXBUF. I have updated the patch to fix bug 467933. The patch also fixes the issue described in https://issues.jboss.org/browse/JBIDE-19853. (In reply to Snjezana Peco from comment #5) > GTK >= 3.14 also sends two signals for cell 0, but only one (paint) for > other cells. I'm trying to understand a bit better. So is this a bug in GTK? If that's the case, it might get fixed in a 3.14.x release and break again. Of course I'm not saying code should work forever :) but if it's a bug in GTK I think it might need a bit further investigation. *** Bug 466229 has been marked as a duplicate of this bug. *** On Ubuntu 12.04 with GTK 3.4.2, https://git.eclipse.org/r/#/c/48343/5 produces rendering artifacts when running attachment 253901 [details]. It looks like the image is always painted twice. The second time, it uses wrong coordinates (image too much in the upper-left). *** Bug 471125 has been marked as a duplicate of this bug. *** *** Bug 471781 has been marked as a duplicate of this bug. *** This should go in 4.5.1. We receive lot of bug requests in egit because of that. (In reply to Markus Keller from comment #9) > On Ubuntu 12.04 with GTK 3.4.2, https://git.eclipse.org/r/#/c/48343/5 > produces rendering artifacts when running attachment 253901 [details]. It > looks like the image is always painted twice. The second time, it uses wrong > coordinates (image too much in the upper-left). The patch is not required for GTK 3.4.2, so probably we miss some checks for GTK >= 3.14.x? (In reply to Markus Keller from comment #9) > On Ubuntu 12.04 with GTK 3.4.2, https://git.eclipse.org/r/#/c/48343/5 > produces rendering artifacts when running attachment 253901 [details]. It > looks like the image is always painted twice. The second time, it uses wrong > coordinates (image too much in the upper-left). With and without the patch, your snippet renders images differently for different versions of GTK. I am not sure what we would have to do within the patch. Images with GTK 3.4.2 are smaller without it. Maybe we should create a new bug. See the attachment. Created attachment 254993 [details]
a screenshot
I can confirm the problem initially described with the empty Path column in the Git commit window in Version: Mars Release (4.5.0), Build id: 20150621-1200. Using GTK 3.16.4. I get the same problem like shown on the attachment "Using GTK3 (43.06 KB, image/png), 2015-05-05 17:44 EDT, Marc-Andre Laperle" Regarding to the fixes discussed here: Is this the same issue or should I raise a new one? (In reply to René Krell from comment #15) > I can confirm the problem initially described with the empty Path column in > the Git commit window in Version: Mars Release (4.5.0), Build id: > 20150621-1200. > Using GTK 3.16.4. > > I get the same problem like shown on the attachment "Using GTK3 (43.06 KB, > image/png), 2015-05-05 17:44 EDT, Marc-Andre Laperle" > > Regarding to the fixes discussed here: Is this the same issue or should I > raise a new one? Yes, it is the same issue. Markus, do you still see the issue and oppose landing the patch? I don't have anything with that old gtk to confirm. *** Bug 451232 has been marked as a duplicate of this bug. *** *** Bug 473192 has been marked as a duplicate of this bug. *** I reproduced the issue on my setup. (F22, Gtk3.16). Then tested path on: Gtk2.24 Gtk3.12 Gtk3.14 Gtk3.16 Now on Gtk3.14+ text is visible in the commit message. Nice. I looked around a child Eclipse and did not find anything to be broken. Doesn't break any JUnit tests either. Gerrit change https://git.eclipse.org/r/48343 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=e32fa8a623210ebcb62b7d869996492857cb244c Pushed to master. New Gerrit change created: https://git.eclipse.org/r/53470 *** Bug 474397 has been marked as a duplicate of this bug. *** Reopening to fix in 4.5.1 Gerrit change https://git.eclipse.org/r/53470 was merged to [R4_5_maintenance]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=a41f152c868984b41b73945f374966ad621c3e13 (In reply to Eclipse Genie from comment #26) > Gerrit change https://git.eclipse.org/r/53470 was merged to > [R4_5_maintenance]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/ > ?id=a41f152c868984b41b73945f374966ad621c3e13 Pushed the patch as Alex and I agreed that it is important to fix this for 4.5.1. *** Bug 467933 has been marked as a duplicate of this bug. *** *** Bug 467511 has been marked as a duplicate of this bug. *** *** Bug 480032 has been marked as a duplicate of this bug. *** FYI: probably there are still few issues left, see bug 480032 and bug 480292 reported for 4.5.1. (In reply to Andrey Loskutov from comment #31) > FYI: probably there are still few issues left, see bug 480032 and bug 480292 > reported for 4.5.1. I can't reproduce the issue. I have tested Eclipse 4.5.1 and the current swt master with GTK 3.10.8, GTK 3.14.13, GTK 3.16.7 and GTK 3.18.2. *** Bug 485759 has been marked as a duplicate of this bug. *** |
Created attachment 253193 [details] Using GTK3 Using Ubuntu 15.04, GTK 3.14.12 Eclipe 4.5-I20150504-2000 EGit 4.0.0.201505042013 Using EGit, open the commit dialog with some files to be committed. The path column has no text. The file names should be visible. See attached screenshot.