Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 466082

Summary: Linked mode ruins rename
Product: [ECD] Orion Reporter: Mark Macdonald <mamacdon>
Component: EditorAssignee: Silenio Quarti <Silenio_Quarti>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: emoffatt, Michael_Rennie
Version: 8.0   
Target Milestone: 9.0   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
rename failing none

Description Mark Macdonald CLA 2015-05-01 10:27:24 EDT
Created attachment 253032 [details]
rename failing

I'm using the new JS "rename member" command to rename a function parameter. I ran into 2 problems:

* If a linked mode group occurs offscreen, the scrollbar tries to reveal the group every time you press a key, causing the viewport to jump up and down.

* If you type too quickly (see attached screencast), characters go into the wrong place and the file is corrupted.
Comment 1 Silenio Quarti CLA 2015-05-25 12:04:21 EDT
The scrolling problem is fixed by the following commit. I was not able to reproduce the second problem. Mark, could you try the latest?

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=6c258a8f4525ffb84e00260621e83d8d439a9b64
Comment 2 Mark Macdonald CLA 2015-05-25 13:27:18 EDT
(In reply to Silenio Quarti from comment #1)
> The scrolling problem is fixed by the following commit. I was not able to
> reproduce the second problem. Mark, could you try the latest?
> 

I can't reproduce it anymore using master. Maybe it was a side effect of the scrolling problem.