Bugzilla – Full Text Bug Listing
| Summary: | Remove "Presentation" theme as it overwrites other settings without a way to restore | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Markus Keller <markus.kell.r> |
| Component: | UI | Assignee: | Simon Scholz <simon.scholz> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | daniel_megert, Lars.Vogel, markus.kell.r, simon.scholz, stephan.herrmann, tom.schindl |
| Version: | 4.5 | Flags: | Lars.Vogel:
review+
|
| Target Milestone: | 4.5 RC1 | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| See Also: |
https://git.eclipse.org/r/47553 https://git.eclipse.org/r/47606 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=84a6ff7fda669eeb3ee68d9ca064fc240942fae0 |
||
| Whiteboard: | |||
| Bug Depends on: | |||
| Bug Blocks: | 466978 | ||
And BTW: Does the Presentation theme really set the font size to 16px? Shouldn't that be 16pt, or just 16? I agree theme is not the right way to switch into presenter mode! Markus, we are extending the default style in the presentation theme. As your are using the classic theme, we are changing your presentation, which is a bad thing. I suggest we remove the presentation theme, I (now) agree with you and Tom that a theme is not a good solution for this requirement, at least not in standard. (In reply to Lars Vogel from comment #3) > I suggest we remove the presentation theme, I (now) agree with you and Tom > that a theme is not a good solution for this requirement, at least not in > standard. Thanks Lars. In case it's not obvious: Here's my +1 for removing the presentation theme in RC1. For the record my take on this is that presentation mode is that you turn your current (color) theme into and it: * increases fonts * hides stuff (eg the statusbar might be hidden) So presentation mode is applied on top of / removed from a current theme so it might be a checkbox only! New Gerrit change created: https://git.eclipse.org/r/47606 Gerrit change https://git.eclipse.org/r/47606 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=84a6ff7fda669eeb3ee68d9ca064fc240942fae0 Thanks Simon, can you also create a Gerrit to remove the entry from the N&N? . See https://git.eclipse.org/r/#/c/47610/ for N&N removal. . I spent some time today hunting the presentation mode which I remembered from the N&N, found bug 459578 incl. the N&N entry and was going nuts why in all my installations I could not see the new theme. It seems also removal of a previously announced feature needs an announcement, no? After-the-fact removal from N&N does not remove all copies (e.g., in people's memory) - not even the original bug had a hint that this was withdrawn later. (In reply to Stephan Herrmann from comment #12) > After-the-fact removal from N&N does not remove all copies (e.g., in > people's memory) - not even the original bug had a hint that this was > withdrawn later. Yes. Sorry for having missed that and thanks for mentioning it. 1984 has passed, and that history refactoring engine still doesn't work reliably... gotta work on that ;-/ |
Switching to the Presentation theme not only changes the text font size, but it also overrides other settings. Example: I work in the "Windows Classic" theme, with custom font "Lucida Console 8" and with custom "View and Editor Folders" colors ("Hue" changed to "70"). - switch to Presentation theme => Font size and font face are overridden to "Consolas 16" => underlying theme is switched to something that looks like the Windows theme => custom "View and Editor Folders" colors are overridden - switch back to "Windows Classic" => Font is reset to "Consolas 10", not to my custom font => custom "View and Editor Folders" colors are reset to default; customizations lost I can only repeat my concerns from bug 462724 that a Theme is not the right solution to change a single font setting.