Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 465955

Summary: Remove useless IUndoableCommand
Product: [Modeling] Sirius Reporter: Esteban DUGUEPEROUX <esteban.dugueperoux>
Component: DiagramAssignee: Project Inbox <sirius.diagram-inbox>
Status: CLOSED FIXED QA Contact: Jessy Mallet <jessy.mallet>
Severity: normal    
Priority: P3 CC: jessy.mallet, maxime.porhel
Version: unspecifiedKeywords: triaged
Target Milestone: 3.1.0   
Hardware: PC   
OS: Linux   
See Also: https://git.eclipse.org/r/46902
https://git.eclipse.org/r/47414
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=4c6eb7c4c416e89b57439811e1a8fb14e12631b0
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=0820dd70e7bd9757787d3df2bdb1965f4c010e13
Whiteboard:

Description Esteban DUGUEPEROUX CLA 2015-04-30 11:18:00 EDT 
The use of IUndoableCommand in SiriusCommand is useless since this last is a RecordingCommand and undo/redo is managed by default. Consequently ICommandTask.undo()/redo() methods are also useless. It is better to leave support of these features to the ChangeRecorder then leave user manage it itself which is error prone.
Comment 1 Eclipse Genie CLA 2015-04-30 11:24:53 EDT 
New Gerrit change created: https://git.eclipse.org/r/46902
Comment 2 Eclipse Genie CLA 2015-05-07 04:28:32 EDT 
New Gerrit change created: https://git.eclipse.org/r/47414
Comment 4 Esteban DUGUEPEROUX CLA 2015-05-07 08:56:20 EDT 
For Sirius 3.0 IUndoableCommand and others have been deprecated and will be removed for 3.1.
Comment 6 Esteban DUGUEPEROUX CLA 2015-07-08 04:32:07 EDT 
Fixed through 0820dd70e7bd9757787d3df2bdb1965f4c010e13.
Comment 7 Jessy Mallet CLA 2015-09-28 09:08:15 EDT 
No validation: Technical issue
Comment 8 Pierre-Charles David CLA 2015-10-16 09:09:04 EDT 
Available in Sirius 3.1.0.