Bugzilla – Full Text Bug Listing
| Summary: | Improve selection of deeply-contained VSM elements | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Modeling] Sirius | Reporter: | Steve Monnier <steve.monnier> | ||||
| Component: | Diagram | Assignee: | Pierre-Charles David <pierre-charles.david> | ||||
| Status: | CLOSED FIXED | QA Contact: | Julien Dupont <julien.dupont> | ||||
| Severity: | major | ||||||
| Priority: | P2 | CC: | esteban.dugueperoux, julien.dupont, laurent.redor, pierre-charles.david, vincent.richard | ||||
| Version: | 2.0.4 | Keywords: | triaged | ||||
| Target Milestone: | 4.1.0 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows 7 | ||||||
| See Also: |
https://git.eclipse.org/r/46895 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=db2ca98f284d3ccbada371ad9ae258d184d0ece7 https://git.eclipse.org/r/79693 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=0e4e25404f21d26012f2598f098570b130fb758b https://git.eclipse.org/r/83037 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=d7b9bc29b1f3bfba6c6a05ad7ad7579b372e8428 |
||||||
| Whiteboard: | |||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 500105 | ||||||
| Attachments: |
|
||||||
|
Description
Steve Monnier
New Gerrit change created: https://git.eclipse.org/r/46895 Note that the previous gerrit is a draft of a solution where the id of the container mapping is displayed before the style label. It is a regression as with the release 6.8 of Sirius before it was open-source, the full qualified name of style was displayed. I change the importance of this bug as it make style customization very hard to do when having several style. This regression occurs since diagram metamodel split in its own .ecore, i.e. diagram.ecore. Because org.eclipse.sirius.diagram.ui.business.internal.dialect.HierarchyLabelProvider.isClassOfDescriptionPackageOrSubPackage() check. Created attachment 259121 [details]
Style customisation's style selection dialog box presenting the styles in an undistinguishable way.
When referencing a style in a style customisation the selection dialog box presents the styles in an undistinguishable way (see screenshot). A workaround for the gradient style is to use named custom colors for the background and foreground colors to distinguish them. But cases occurs where the styles distinguish in other ways than the foreground and background colors (it could be the label expression, the lable color, etc.) If the styles were named, it would be easy to find the correct one. At least, the mapping's name containing the style could pe displayed to help improve the customer expericence. Too late for 4.0, but will probably be done in 4.1 (to be released around november). Depending on the impacts, it may be backported to a 4.0.x maintenance release. Taking this, I've updated and reworked a little the existing patch. Gerrit change https://git.eclipse.org/r/46895 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=db2ca98f284d3ccbada371ad9ae258d184d0ece7 Fixed, but still needs automated tests. New Gerrit change created: https://git.eclipse.org/r/79693 Gerrit change https://git.eclipse.org/r/79693 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=0e4e25404f21d26012f2598f098570b130fb758b Fixed. New Gerrit change created: https://git.eclipse.org/r/83037 Gerrit change https://git.eclipse.org/r/83037 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=d7b9bc29b1f3bfba6c6a05ad7ad7579b372e8428 Available in Sirius 4.1.0, see https://wiki.eclipse.org/Sirius/4.1.0 for details. |