Bugzilla – Full Text Bug Listing
| Summary: | [GTK3] [Decorators] Overdrawn of label decorators | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Lars Vogel <Lars.Vogel> | ||||||||||
| Component: | SWT | Assignee: | Snjezana Peco <snjezana.peco> | ||||||||||
| Status: | RESOLVED WORKSFORME | QA Contact: | Sravan Kumar Lakkimsetti <sravankumarl> | ||||||||||
| Severity: | major | ||||||||||||
| Priority: | P3 | CC: | akurtakov, arunkumar.thondapu, ericwill, johannes.degler, Lars.Vogel, lshanmug, pradeepb, snjezana.peco, sravankumarl | ||||||||||
| Version: | 4.5 | Keywords: | triaged | ||||||||||
| Target Milestone: | 4.6 | ||||||||||||
| Hardware: | PC | ||||||||||||
| OS: | Linux | ||||||||||||
| See Also: | https://git.eclipse.org/r/54854 | ||||||||||||
| Whiteboard: | |||||||||||||
| Attachments: |
|
||||||||||||
To reproduce: 1.) Download SDK 2.) Install EGit 3.) Switch to dark theme, restart 4.) Change a file in the project explorer to trigger the EGit icon decorators -> Overdrawn in several cases the decoration. Created attachment 252958 [details]
Label background (set to dark) seem to come through
Unable to reproduce on Ubuntu 14.04 with M7 build (4.5.0.I20150430-1445). Lars, this seems very much like a duplicate of bug 459117, did you try with a recent build which has the fix for that bug? Can you please confirm with M7? I spent some more time to try and reproduce this problem and a couple of updates: 1. I was indeed able to reproduce the problem using the Dark theme but not very consistently, it was a very random and infrequent occurrence in my observation. 2. I was never able to reproduce the problem when not using the Dark theme (I was using the default GTK theme). 3. The problem when it happens does seem restricted to projects which have changes and thus have icons decorated from EGit i.e projects with regular non-decorated icons seem fine. Considering the bug affects only the Dark theme and is not consistently reproducible there too, I'm not sure this should be an RC1 candidate... More updates: 1. I'm able to reproduce this consistently now with the latest I-build 4.5.0.I20150510-2000 on Ubuntu 14.04 but not on Ubuntu 12.04, so it seems to be a GTK+ 3.10 related issue. 2. It can be seen in the Package Explorer as well as in the Project Explorer. 3. I was trying to debug but I don't see the problem when running a self-hosted eclipse application. I noticed that in the original eclipse launch, the projects with changes are highlighted in blue along with the addition of a > symbol to the icons, but in the self-hosted eclipse, I don't see the blue highlighting. Lars, any idea why this could be happening? I suspect that might have something to do with the problem not appearing when I run the self-hosted eclipse application. (In reply to Arun Thondapu from comment #5) > 3. I was trying to debug but I don't see the problem when running a > self-hosted eclipse application. I noticed that in the original eclipse > launch, the projects with changes are highlighted in blue along with the > addition of a > symbol to the icons, but in the self-hosted eclipse, I don't > see the blue highlighting. Lars, any idea why this could be happening? I > suspect that might have something to do with the problem not appearing when > I run the self-hosted eclipse application. I think we are seeing the EGit decoration for changed files. You your runtime Eclipse must include EGit and the target workspace should have projects with are under version control and files which are changed. (In reply to Lars Vogel from comment #6) > (In reply to Arun Thondapu from comment #5) > > > 3. I was trying to debug but I don't see the problem when running a > > self-hosted eclipse application. I noticed that in the original eclipse > > launch, the projects with changes are highlighted in blue along with the > > addition of a > symbol to the icons, but in the self-hosted eclipse, I don't > > see the blue highlighting. Lars, any idea why this could be happening? I > > suspect that might have something to do with the problem not appearing when > > I run the self-hosted eclipse application. > > I think we are seeing the EGit decoration for changed files. You your > runtime Eclipse must include EGit and the target workspace should have > projects with are under version control and files which are changed. All of this is true in my case, see bug 466515 comment 6. I suspect this is a different manifestation of bug 459117 as mentioned in comment 3. I've suggested a change in Tree.java which will most probably fix this bug and the change has been merged as part of the fix for bug 465309. Will test in tonight's I-build and verify whether it gets fixed or not... (In reply to Arun Thondapu from comment #8) > I suspect this is a different manifestation of bug 459117 as mentioned in > comment 3. I've suggested a change in Tree.java which will most probably fix > this bug and the change has been merged as part of the fix for bug 465309. > Will test in tonight's I-build and verify whether it gets fixed or not... The problem is still there in the latest I-build, will try to investigate a fix for RC2. Adding Snjezana as this is similar to the problem in bug 459117 but the fix for that one does not fix this problem, this one is specific to the dark theme though, it cannot be reproduced in the normal GTK theme. Could not complete in time for 4.5.1. It requires some more effort. Will target for M3 I can't reproduce the issue on Mars. (In reply to Snjezana Peco from comment #12) > I can't reproduce the issue on Mars. Hi, It is reproducible. I am using ubuntu 14, GTK3.10, dark theme with egit. 1. Import project from egit. 2. Modify some files in the project so that the modified decoration comes up on the project. 3. Expand the modified project in project explorer 4. select any other project 5. Switch focus to editor by clicking on the editor pane 6. click close all button on the project explorer. Now you should be able to see the problem. Please note this problem does not appear in runtime workbench -Sravan New Gerrit change created: https://git.eclipse.org/r/54854 (In reply to Sravan Kumar Lakkimsetti from comment #13) > Hi, > > It is reproducible. I am using ubuntu 14, GTK3.10, dark theme with egit. > 1. Import project from egit. > 2. Modify some files in the project so that the modified decoration comes up > on the project. > 3. Expand the modified project in project explorer > 4. select any other project > 5. Switch focus to editor by clicking on the editor pane > 6. click close all button on the project explorer. > > Now you should be able to see the problem. > > Please note this problem does not appear in runtime workbench > > -Sravan Finaly I have succeeded to reproduce the issue in the following way: - select Window>Preferences>General>Appearance>Colors and Fonts, expand the Git tree item and change the "Uncommitted Change (Background)" preference. After that, it is easy to reproduce the issue if you have a git repository with some uncommitted changes. It can be reproduced in GTK3 > 3.9.0 and <= 3.14.12 when using any themes including GTK. It can also be reproduced in runtime workbench. I suppose this is a GTK bug fixed in GTK >= 3.14.12 I have created a workaround (https://git.eclipse.org/r/54854) that works so that it ignores the colour of the item background for GTK3 > 3.9.0 and <= 3.14.12. This way, the issue can't be reproduced in GTK2 and GTK3 >= 3.14.12. Eclipse SWT won't paint the colour of the item background on GTK 3.10 and GTK 3.12, but the issue won't happen when using the default preferences settings. The issue still happens on GTK >= 3.14.0 and < 3.14.12 when the background is changed. Not sure if we can do anything for those versions, but, since most newer distributions use GTK >= 3.14.12 it doesn't matter, in my opinion. I observed this in the package explorer - the Git repo info alongside the projects are shown on top of the editor area, spilling over from the package explorer. I am seeing this in the Mars.1 JEE package, while using it out of the box - that is, just the default theme, in a brand new workspace. In fact, this is observed on a new VM was recently built. Here are the details: Linux: 64-bit Ubuntu 3.19.0-15-generic Eclipse: Mars.1 JEE package, Linux 64-bit GTK+ Version: 3.14.13-0ubuntu1 Eclipse SWT internal variable: org.eclipse.swt.internal.gtk.version=3.14.13 (In reply to Pradeep Balachandran from comment #16) > I observed this in the package explorer - the Git repo info alongside the > projects are shown on top of the editor area, spilling over from the package > explorer. > I am seeing this in the Mars.1 JEE package, while using it out of the box - > that is, just the default theme, in a brand new workspace. In fact, this is > observed on a new VM was recently built. > > Here are the details: > Linux: 64-bit Ubuntu 3.19.0-15-generic > Eclipse: Mars.1 JEE package, Linux 64-bit > GTK+ Version: 3.14.13-0ubuntu1 > Eclipse SWT internal variable: org.eclipse.swt.internal.gtk.version=3.14.13 The desktop environment used here is gnome not unity connected through VNC I have been unable to reproduce this bug, both using Lars' or Snjezana's steps to reproduce. I've tried on GTK3.14.9 all the way to GTK3.18.2. I suspect this was a GTK bug that was fixed awhile ago upstream. I also have not seen that issue in a very long time. Sorry I forgot that this bug is still open. I suggest to close it as worksforme. (In reply to Lars Vogel from comment #19) > I also have not seen that issue in a very long time. Sorry I forgot that > this bug is still open. I suggest to close it as worksforme. Sure, I'll mark it as closed. If anyone objects please feel free to re-open. Created attachment 258428 [details]
Leaking text on labels
The Bug is still reproducible on
OS: Ubuntu 15.04
GTK: 3.14.13
Java: Oracle Java 1.8 update 66
Desktop: Gnome
Connection: VNC
Eclipse build: I20151201-1100
Please refer to attached screen shot
Reopening as it is still reproducible on Ubuntu 15.04 What is the status of this one? I haven't experienced it in long time and the changes are significant since last comment onthebug. (In reply to Alexander Kurtakov from comment #23) > What is the status of this one? I haven't experienced it in long time and > the changes are significant since last comment onthebug. Same here, I have not seen then in a long time. IMHO this can be marked as closed. Closing it based on Lars comments Created attachment 279063 [details]
Screenshot overdrawn labels
I'm experiencing the exact same bug on two separate machines with an up to date GTK 3 version. As I only switched to Linux recently, I don't know if this is a regression in GTK or if this bug was never really fixed. If you need any further details, Ill gladly provide them. (In reply to Johannes Degler from comment #27) > I'm experiencing the exact same bug on two separate machines with an up to > date GTK 3 version. As I only switched to Linux recently, I don't know if > this is a regression in GTK or if this bug was never really fixed. > > If you need any further details, Ill gladly provide them. I assume you run with Gtk 3.24.9, I've experienced the same issue yesterday after updating my machine. Everything was fine up to 3.24.8 - Eric is investigating it. (In reply to Johannes Degler from comment #27) > I'm experiencing the exact same bug on two separate machines with an up to > date GTK 3 version. As I only switched to Linux recently, I don't know if > this is a regression in GTK or if this bug was never really fixed. > > If you need any further details, Ill gladly provide them. Please see bug 548629 if you are running GTK3.24.9. |
Created attachment 252950 [details] Screenshot Hard to reproduce but I see frequently label overdrawn, especially in the dark theme.