Bugzilla – Full Text Bug Listing
| Summary: | [Graphics] Consolidate org.eclipse.pde.ua.ui/full/icons and /icons/full folder from org.eclipse.ui.images | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Lars Vogel <Lars.Vogel> | ||||
| Component: | UI | Assignee: | Matthias Becker <ma.becker> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | Lars.Vogel, markus.kell.r | ||||
| Version: | 4.5 | ||||||
| Target Milestone: | 4.7 M3 | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| See Also: |
https://git.eclipse.org/r/46826 https://git.eclipse.org/r/46827 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=c7c7ce35aff40617d3aee078d665ac0f6d6962df https://git.eclipse.org/r/80800 https://git.eclipse.org/c/platform/eclipse.platform.images.git/commit/?id=5eb7081915bc62f855a06f63fed6a76ec21e7e5f |
||||||
| Whiteboard: | |||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 465778 | ||||||
| Attachments: |
|
||||||
|
Description
Lars Vogel
Tony, can you provide a Gerrit review for this change? New Gerrit change created: https://git.eclipse.org/r/46826 New Gerrit change created: https://git.eclipse.org/r/46827 WARNING: this patchset contains 1728 new lines of code and may require a Contribution Questionnaire (CQ) if the author is not a committer on the project. Please see:https://wiki.eclipse.org/Project_Management_Infrastructure/Creating_A_Contribution_Questionnaire Created attachment 252920 [details]
April 29 2015 Gallery
Gerrit change https://git.eclipse.org/r/46827 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=c7c7ce35aff40617d3aee078d665ac0f6d6962df Thanks Tony, forgot to close this one. This was consolidated the wrong way around. org.eclipse.pde.ua.ui misses the "full" folder and has e.g. /org.eclipse.pde.ua.ui/icons/obj16 The structure in org.eclipse.images has to match the structure in the production repo, and as long as that's not corrected, the "full" folder in org.eclipse.images is harmful, since it e.g. broke the generated HiDPI fragment from bug 382972 comment 92. I only didn't fix this in master to avoid conflicts with https://git.eclipse.org/r/#/c/71351/ Matthias, something for you? New Gerrit change created: https://git.eclipse.org/r/80800 Gerrit change https://git.eclipse.org/r/80800 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.images.git/commit/?id=5eb7081915bc62f855a06f63fed6a76ec21e7e5f Thanks Matthias |