Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 465680

Summary:	Better labels and descriptions for Eclipse 4 project template
Product:	[Eclipse Project] PDE	Reporter:	Lars Vogel <Lars.Vogel>
Component:	UI	Assignee:	Lars Vogel <Lars.Vogel>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	daniel_megert, Lars.Vogel, simon.scholz, Vikas.Chandra
Version:	4.5	Flags:	Lars.Vogel: review+ Vikas.Chandra: review+ simon.scholz: review+
Target Milestone:	4.5 RC3
Hardware:	PC
OS:	Linux
See Also:	https://git.eclipse.org/r/46738 https://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=b4f195b27d24a67b7017edb271fe5cdf429727b8
Whiteboard:
Bug Depends on:	441331
Bug Blocks:

Description Lars Vogel

2015-04-28 08:29:32 EDT

Bug 441331 integrated the e4 project template.

I think we should improve the labels:

Create Sample Content -> Create sample content
Create Life Cycle -> Add life cycle class
Simple Eclipse 4 Application -> Basic Eclipse 4 Application

Template description should also be updated, as it does not always create a part and basis commands.

I provide a Gerrit review.

Comment 1 Vikas Chandra

2015-04-28 13:19:44 EDT

Moving it out of M7 - can move back to 4.5M7 with gerrit code if required.

Comment 2 Eclipse Genie

2015-04-29 04:21:41 EDT

New Gerrit change created: https://git.eclipse.org/r/46738

Comment 3 Vikas Chandra

2015-04-29 08:39:40 EDT

This template creates an Eclipse 4 RCP application that consists of an ap
plication window and optional with a part, several commands and a life cycle class.



Instead of above, the following below should be considered ( if that is the case)


This template creates an Eclipse 4 RCP application that consists of an ap
plication window and optionally consists of a part, several commands and a life cycle class.

Comment 4 Lars Vogel

2015-04-29 09:24:50 EDT

(In reply to Vikas Chandra from comment #3)
> This template creates an Eclipse 4 RCP application that consists of an ap
> plication window and optional with a part, several commands and a life cycle
> class.
> 
> 
> 
> Instead of above, the following below should be considered ( if that is the
> case)
> 
> 
> This template creates an Eclipse 4 RCP application that consists of an ap
> plication window and optionally consists of a part, several commands and a
> life cycle class.

+1

Comment 5 Vikas Chandra

2015-05-06 04:33:42 EDT

Gerrit patch is not updated with new text. Can you please update?

Comment 6 Vikas Chandra

2015-05-08 08:05:27 EDT

Moving to M6.

Please move back to 4.5RC1 if the patch is updated.

Comment 7 Eclipse Genie

2015-05-26 10:59:38 EDT

Gerrit change https://git.eclipse.org/r/46738 was merged to [master].
Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=b4f195b27d24a67b7017edb271fe5cdf429727b8

Comment 8 Lars Vogel

2015-05-26 11:00:33 EDT

Olivier did the update as requested by Vikas. As this is only an update of the description I think I goes in the gray area of "documentation".

Comment 9 Dani Megert

2015-05-26 11:11:10 EDT

(In reply to Lars Vogel from comment #8)
> Olivier did the update as requested by Vikas. As this is only an update of
> the description I think I goes in the gray area of "documentation".

It's not a grey area. Documentation is Javadoc and doc in the commons repository. Please get the required approvals or revert for the next build.

Comment 10 Lars Vogel

2015-05-26 15:13:37 EDT

(In reply to Dani Megert from comment #9)
> repository. Please get the required approvals or revert for the next build.

Done

Comment 11 Vikas Chandra

2015-05-28 06:02:12 EDT

verified in
Version: Mars (4.5)
Build id: I20150527-2010